magento2
magento2 copied to clipboard
magento
27550 - Fix UX issue on Admin > Content > Pages/Blocks grid
Description (*)
I want to share reasons why I have removed quick edit functionality on grid page
- Most often
Title,Url, andLayoutare permanent and need not quick editing on the grid page. Customer often editContent,Search Engine Optimization,Custom Design Updatesections. We have to go to edit page any way - I as customer want to edit content quickly without redundant moves.
But I have to do two clicks
Select > Editto go to edit section of Cms Page/Block. Sometimes even four clicksClick to need page/block -> cancel -> Select > Editif I forgot about quick editing.
If I will edit Cms content very often It isn't user friendly interface for me and customers whole.
Yes we can apply this solution #27614 , yes it's good. But we can't get rid of two clicks to go to edit page.
I think removing quick editing functionality on the grid will save time people who works with Magento. And they will spend this time for others things.
This PR adds such ability only One click on the grid and we are on the Edit page. Also this PR fixed this issue #27550 It's one more confirmation than we need to avoid redundant clicks to go to Edit Cms Page/Blocks
Actual result Block grid
Actual result Page grid
Related Pull Requests
Fixed Issues (if relevant)
- Fixes magento/magento2#27550 : Fix UX issue on Admin > Content > Pages/Blocks grid
Hi @Usik2203. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:
@magento give me test instance- deploy test instance based on PR changes@magento give me 2.4-develop instance- deploy vanilla Magento instance
For more details, please, review the Magento Contributor Guide documentation.
![m2-assistant[bot] avatar](https://avatars.githubusercontent.com/in/27048?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you
Hi @Usik2203, here is your new Magento instance.
Admin access: https://pr-27623.instances.magento-community.engineering/admin_f7df
Login: b19f1643 Password: e1db378667f3
Instance will be terminated in up to 3 hours.
I would like just to drop it, but I agree that this change should be approved by product owner
On Sun, 5 Apr 2020 at 16:04, Yaroslav Rogoza [email protected] wrote:
@rogyar requested changes on this pull request.
Hi @Usik2203 https://github.com/Usik2203. Thank you for your collaboration. That approach might be tricky. If I understand correctly, you just removed the inline edit possibility. In that way we are changing the existing system behavior.
I'm not sure we should simply remove this possibility (even if it's useless, I agree) from the product owners approval perspective. Maybe we should consider something like proposed in the following PR?
#27614 https://github.com/magento/magento2/pull/27614
@ihor-sviziev https://github.com/ihor-sviziev what do you think?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/pull/27623#pullrequestreview-387816951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOJOUKZCYIAI76G2IAFYZTRLB6XTANCNFSM4MAQPO7Q .
Hi @Usik2203. Could I kindly ask you to extend the PR description slightly, please? So what is the main reason for your decision to remove this functionality but not to adjust it somehow. It's necessary for the final decision on how to proceed with the solution.
Thank you!
Hi @Usik2203. Could I ask you to adjust the MFTF test to follow the best practices, please? You have good expertise in creating the MFTF tests, so you should have no problem with that.
Thank you!
Hi @rogyar , @gabrieldagama I have applied your recommendations. Failed tests seems are not related with my changes
Thanks
@Usik2203 please update your PR accordingly to https://github.com/magento/magento2/pull/27623#discussion_r505656213 https://github.com/magento/magento2/pull/27623#discussion_r505656551. Thank you.
@Usik2203 please look at https://github.com/magento/magento2/pull/27623#discussion_r505656213 https://github.com/magento/magento2/pull/27623#discussion_r505656551. Otherwise, we can't proceed with your PR. Thank you.
Hi @engcom-Charlie I have applied https://github.com/magento/magento2/pull/27623#discussion_r505656213 recommendations Thanks
:heavy_check_mark: QA Passed
Manual testing scenario:
- Go to Admin > Content > Pages
- Click on any place on the row (except "Action" column)
Before: :heavy_multiplication_x: "Quick edit" opens, but it actually useless.
After: :heavy_check_mark: Navigated to "edit" page
- Go to Admin > Content > Blocks
- Click on any place on the row (except "Action" column)
Before: :heavy_multiplication_x: "Quick edit" opens, but it actually useless.
After: :heavy_check_mark: Navigated to "edit" page
Hi @rogyar, thank you for the review. ENGCOM-8408 has been created to process this Pull Request :eight_spoked_asterisk: @rogyar, could you please add one of the following labels to the Pull Request?
| Label | Description |
|---|---|
Auto-Tests: Covered |
All changes in Pull Request is covered by auto-tests |
Auto-Tests: Not Covered |
Changes in Pull Request requires coverage by auto-tests |
Auto-Tests: Not Required |
Changes in Pull Request does not require coverage by auto-tests |
@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B
HI @gabrieldagama
I see that failed tests are not related with my changes
Thanks
@gabrieldagama Can we make sure the filters are clear before performing the action?
I didn't find way to do this .
Yes, I can create additional assertion to be sure that filters are clear but in case is it will not be true test will be failed.
Now tests looks good.
Thanks