magento2-phpstorm-plugin icon indicating copy to clipboard operation
magento2-phpstorm-plugin copied to clipboard

[Bug] Possible NullPointerException exception in actions/generation/dialog/InjectAViewModelDialog.java:145

Open bohdan-harniuk opened this issue 2 years ago • 9 comments

Describe the bug (*)

PhpStorm highlights possible NullPointerException exception in actions/generation/dialog/InjectAViewModelDialog.java:145.

Expected behavior (*)

We should add a check for null value here.

Please complete the following information: (*)

  • OS: any
  • PhpStorm/Intellij version: any
  • Plugin Version: 4.4.0

Additional context

Mainline branch: 4.4.1-develop

bohdan-harniuk avatar Sep 21 '22 10:09 bohdan-harniuk

Hi @bohdan-harniuk. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


m2-assistant[bot] avatar Sep 21 '22 10:09 m2-assistant[bot]

I would be interested in taking on this issue

Mgonzalez-droid avatar Sep 21 '22 10:09 Mgonzalez-droid

Hello, @Mgonzalez-droid!

You can proceed with it.

bohdan-harniuk avatar Sep 21 '22 10:09 bohdan-harniuk

Thank you! @bohdan-harniuk

Mgonzalez-droid avatar Sep 21 '22 10:09 Mgonzalez-droid

@Mgonzalez-droid, please, assign it on yourself if you work on it.

bohdan-harniuk avatar Sep 21 '22 10:09 bohdan-harniuk

It may be a security setting but I can't assign myself. The option seems to be disabled for me. Could you assign it to me?

Mgonzalez-droid avatar Sep 21 '22 10:09 Mgonzalez-droid

It seems it is due to me not being a collaborator @bohdan-harniuk

Mgonzalez-droid avatar Sep 21 '22 10:09 Mgonzalez-droid

@Mgonzalez-droid, just use what is said here

Screenshot 2022-09-21 at 14 43 15

bohdan-harniuk avatar Sep 21 '22 11:09 bohdan-harniuk

@magento I am working on this

Mgonzalez-droid avatar Sep 21 '22 19:09 Mgonzalez-droid

Hello @bohdan-harniuk I am new to Open Source and would like to contribute in this issue.

pranjal09J avatar Sep 28 '22 06:09 pranjal09J

Hello, @pranjal09J! Great to hear that. @Mgonzalez-droid has already taken this issue. So, let him finish this issue, you can take another one with the good first issue label (once it will be here). Regards,

bohdan-harniuk avatar Sep 28 '22 08:09 bohdan-harniuk

Thanks. I will look for some other issue.

pranjal09J avatar Sep 28 '22 09:09 pranjal09J

Hello @bohdan-harniuk I am new to open source and would like to contribute in this project .

ishu-thakur avatar Sep 30 '22 06:09 ishu-thakur