magento2-phpstorm-plugin icon indicating copy to clipboard operation
magento2-phpstorm-plugin copied to clipboard

406: added sorting plugin list marker

Open korovitskyi opened this issue 2 years ago • 0 comments

Description (*) It was added by sorting the plugin parkers depending on it's "before" "around" or "after" plugin, and by the sortOrder attribute value.

But it was not included in sorting by the module sequence. Here we should add the parsing config.php file and provide an array with the module name and sequence value. Please to implement it was added the note @TODO at the the com.magento.idea.magento2plugin.linemarker.php.PluginLineMarkerProvider.PluginClassCache#getPluginMethods(java.util.List<com.magento.idea.magento2plugin.stubs.indexes.data.PluginData>)

Actual results: In the first file, you can see the list sorted by sortOrder value and the correct list for the after plugin after around. In the second file, you can see that the vendor plugin, which has no sortOrder attribute has the highest priority.

https://user-images.githubusercontent.com/74533818/176269960-61f9786b-11fe-4955-a56b-3b1fdf31a920.mov

Questions or comments To compleat this part we here need add the module sequence condition: the logic to sort is implemented, need just add module sequence value.

Also in the future will be good mark the area of plugins list:

  • around before/after proceed;
  • methods wich where disabled or not working, because callable was not callable.

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with integration/functional tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

korovitskyi avatar Jun 28 '22 19:06 korovitskyi