magento2-phpstorm-plugin icon indicating copy to clipboard operation
magento2-phpstorm-plugin copied to clipboard

Published 20 hours ago • verified publisher icon magento

UCT live inspection only includes PHP and XML files

Open svera opened this issue 2 years ago • 4 comments

Describe the bug (*) The built-in UCT only checks PHP and XML files in live inspection. For example, checking magepal/magento2-core version 1.1.12, bundle UCT returns a bunch of deprecated warnings for escapeHtml() in view/adminhtml/templates/system/config/field/extensions.phtml which are not reflected in live inspection.

To Reproduce (*)

Steps to reproduce the behaviour:

  1. Install magepal/magento2-googletagmanager 2.7.1 in a Magento instance using composer (magepal/magento2-core is installed also as a requirement): composer require magepal/magento2-googletagmanager
  2. Analyse magepal/magento2-core from the vendorfolder using the built-in UCT
  3. After UCT finishes its analysis, open view/adminhtml/templates/system/config/field/extensions.phtml from the analysis results
  4. Live inspection of file above should highlight the errors found by UCT

Expected behaviour (*)

Issues in PHTML and other file extensions supported by UCT should be highlighted in live inspection.

Screenshots

Screenshot 2022-05-16 at 11 47 55

Please complete the following information: (*)

  • OS: Mac OS 12.1 Montereey
  • PhpStorm/Intellij version: 2022.1
  • Plugin Version: 4.3.1

svera avatar May 16 '22 10:05 svera

Hi @svera. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this

m2-assistant[bot] avatar May 16 '22 10:05 m2-assistant[bot]

Hello, @svera!

This is not a bug. You should configure path to analyse for the live inspection to work with. Please, provide your configuration.

Regards,

bohdan-harniuk avatar May 16 '22 13:05 bohdan-harniuk

Hi @bohdan-harniuk , path is already provided, see next screenshot: Screenshot 2022-05-17 at 11 15 48

also, live inspection is working fine in PHP files, as you can see in the attached image:

Screenshot 2022-05-17 at 11 20 37

svera avatar May 17 '22 09:05 svera

@svera, *.phtml files are working fine for app/code and app/design directories. It seems, that the problem appears with the 3rd party modules in the vendor directory. I'll check this issue.

Thank you, for your report!

bohdan-harniuk avatar May 17 '22 10:05 bohdan-harniuk