magento2-page-builder icon indicating copy to clipboard operation
magento2-page-builder copied to clipboard

Tailwindui css layout support - colon is not accepted by the pattern

Open in-session opened this issue 4 years ago • 24 comments

Ashampoo_Snap_Mittwoch, 10  November 2021_09h34m59s_002_

https://tailwindcss.com/docs/responsive-design#overview https://github.com/magento/magento2/pull/34559

Resolved issues:

  1. [x] resolves magento/magento2-page-builder#859: Tailwindui css layout support - colon is not accepted by the pattern

in-session avatar Nov 10 '21 08:11 in-session

@magento run all tests

paras89 avatar Jun 20 '22 13:06 paras89

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@in-session can you pull develop branch into your fork's branch and re-run the tests? After that once the test results are out I can help you fix them!

paras89 avatar Jun 21 '22 09:06 paras89

@magento run all tests

in-session avatar Jun 23 '22 15:06 in-session

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests B2B Functional Tests EE

in-session avatar Jun 24 '22 06:06 in-session

Failed to run the builds. Please try to re-run them later.

@magento run Functional Tests B2B, Functional Tests EE

in-session avatar Jun 24 '22 06:06 in-session

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests B2B

paras89 avatar Jun 27 '22 10:06 paras89

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests B2B

in-session avatar Jun 30 '22 13:06 in-session

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

I think failing tests are not related to changes from this PR

in-session avatar Jun 30 '22 13:06 in-session

@magento run Functional Tests B2B

paras89 avatar Jul 28 '22 14:07 paras89

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Follow-up on https://github.com/magento/magento2/pull/37563

in-session avatar Jun 01 '23 06:06 in-session

@magento create issue

engcom-Hotel avatar Dec 27 '23 05:12 engcom-Hotel

Hi @in-session,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Before: :heavy_multiplication_x: 

colon is not accepted by the pattern.

Screenshot from 2023-12-27 13-03-32

After: :heavy_check_mark:  

colon is accepted by the pattern.

Screenshot from 2023-12-27 15-23-29

Thanks.

engcom-Bravo avatar Dec 27 '23 11:12 engcom-Bravo

@magento run all tests

engcom-Hotel avatar Jan 17 '24 06:01 engcom-Hotel

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

:heavy_check_mark: QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Before: :heavy_multiplication_x: 

colon is not accepted by the pattern.

After: :heavy_check_mark:  

colon is accepted by the pattern.

Thanks.

engcom-Bravo avatar Jan 17 '24 09:01 engcom-Bravo

@magento run all tests

engcom-Hotel avatar Mar 11 '24 07:03 engcom-Hotel

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests

engcom-Hotel avatar Mar 11 '24 09:03 engcom-Hotel

We can close this PR as it has already been merged.

engcom-Hotel avatar Aug 07 '24 13:08 engcom-Hotel