magento-composer-installer icon indicating copy to clipboard operation
magento-composer-installer copied to clipboard

Add __constructor 3rd parameter's default value

Open allanpaiste opened this issue 7 years ago • 3 comments

Encountered an error when upgrading to Magento EE 2.1.6 relates to the fact that under certain considtions Modman parser will have no contructor arguments defined (which used to be expected in the original module that magento team has forked). Due to that module stating that it's a replacement for magento-hackathon module, I would expect the __construct setup to remain intact for it to really serve as areplacement. Therefore, a default value was introduced for the third argument.

- Installing colinmollenhour/cache-backend-file (1.4)
  Loading from cache
[ErrorException]
Missing argument 3 for MagentoHackathon\Composer\Magento\ModmanParser::__construct(), called in phar:///usr/local/bin/composer/src/Composer/Plugi
n/PluginManager.php(195) : eval()'d code on line 318 and defined

allanpaiste avatar Apr 21 '17 12:04 allanpaiste

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

magento-cicd2 avatar Apr 21 '17 12:04 magento-cicd2

Approved

piotrekkaminski avatar Feb 27 '19 16:02 piotrekkaminski

Cool! I don't have the authority to merge this though. But it's cool that it finally got approved :)

allanpaiste avatar Feb 21 '21 11:02 allanpaiste