magento-composer-installer
magento-composer-installer copied to clipboard
Add __constructor 3rd parameter's default value
Encountered an error when upgrading to Magento EE 2.1.6 relates to the fact that under certain considtions Modman parser will have no contructor arguments defined (which used to be expected in the original module that magento team has forked). Due to that module stating that it's a replacement for magento-hackathon module, I would expect the __construct setup to remain intact for it to really serve as areplacement. Therefore, a default value was introduced for the third argument.
- Installing colinmollenhour/cache-backend-file (1.4)
Loading from cache
[ErrorException]
Missing argument 3 for MagentoHackathon\Composer\Magento\ModmanParser::__construct(), called in phar:///usr/local/bin/composer/src/Composer/Plugi
n/PluginManager.php(195) : eval()'d code on line 318 and defined
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Approved
Cool! I don't have the authority to merge this though. But it's cool that it finally got approved :)