magento-coding-standard icon indicating copy to clipboard operation
magento-coding-standard copied to clipboard

No plugins in `\Magento\Framework` namespace

Open lbajsarowicz opened this issue 4 years ago • 1 comments

Rule

Based on https://github.com/magento/magento2/issues/27962: \Magento\Framework cannot have plugins

Reason

Implementation

lbajsarowicz avatar Apr 24 '20 09:04 lbajsarowicz

@lbajsarowicz I also found 2 plugins in the commerce edition, and they are exactly the same

vendor/magento/module-scalable-checkout/etc/di.xml

<type name="Magento\Framework\Model\ResourceModel\Db\ObjectRelationProcessor">
    <plugin name="object_constraints_resolver" type="Magento\Framework\ForeignKey\ObjectRelationProcessor\Plugin" />
</type>

vendor/magento/module-scalable-oms/etc/di.xml

<type name="Magento\Framework\Model\ResourceModel\Db\ObjectRelationProcessor">
    <plugin name="object_constraints_resolver" type="Magento\Framework\ForeignKey\ObjectRelationProcessor\Plugin" />
</type>

DmitryFurs avatar Nov 20 '20 10:11 DmitryFurs