magento-cloud icon indicating copy to clipboard operation
magento-cloud copied to clipboard

less strict string matching in magento-vars.php

Open taoufiqaitali opened this issue 4 years ago • 5 comments

this changes fix issue #446 to allow writing less strict strings to check domains and sub domains

Description

Fixed Issues (if relevant)

  1. magento/magento-cloud#446: less strict string matching in magento-vars.php

Contribution checklist

  • [ 1] Pull request has a meaningful description of its purpose
  • [ 1] All commits are accompanied by meaningful commit messages

taoufiqaitali avatar May 20 '20 10:05 taoufiqaitali

Hi @taoufiqaitali , thank you for your contribution. In the discussion with @joeshelton-wagento in https://github.com/magento/magento-cloud/issues/446 we talk about moving the whole code to the comments to let people know that it is not the only function they may use and will be more clear that they may modify it for their needs. So, I would suggest to comment out this function.

NadiyaS avatar May 26 '20 20:05 NadiyaS

Hi @taoufiqaitali, Will you be able to change your PR using suggested changed I wrote in previous comment?

NadiyaS avatar Jun 24 '20 04:06 NadiyaS

Hi @NadiyaS I just seen the comment Ok i will change it

taoufiqaitali avatar Jun 24 '20 08:06 taoufiqaitali

@NadiyaS ok i added it as comment so people can choice what method to use

taoufiqaitali avatar Jun 25 '20 16:06 taoufiqaitali

The internal task MCLOUD-8939 was created.

BaDos avatar Jun 29 '22 19:06 BaDos