m2-devtools icon indicating copy to clipboard operation
m2-devtools copied to clipboard

MC-19247: Broken translations with advanced bundling

Open adifucan opened this issue 5 years ago • 1 comments

  • Load dictionary before js bundles;

This PR is a:

  • [ ] New feature
  • [X] Enhancement/Optimization
  • [ ] Refactor
  • [ ] Bugfix
  • [ ] Test for existing code
  • [ ] Documentation

Summary

When this pull request is merged, it will move shared.js and page specific bundle js further after require.js. Currently advanced bundling generated bundles go right after require.js in DOM. With this PR they will come later after require.js so it will be possible to insert custom assets like dictionary before bundles.

Additional information

adifucan avatar Sep 23 '19 15:09 adifucan

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

magento-cicd2 avatar Sep 23 '19 15:09 magento-cicd2