inventory icon indicating copy to clipboard operation
inventory copied to clipboard

feat(#38488): check source_code integrity during source_item mass save

Open theuargb opened this issue 1 year ago • 9 comments

Description (*)

This fixes the mentioned issue by implementing a fast integrity check for the source code while saving multiple source items, including mixed-case scenarios.

The proposed solution feels in line with the original feature implementation, giving almost no overhead (1 [indexed] SQL query).

Fixed Issues (if relevant)

  1. Fixes magento/magento#38488: Inventory source item's source_code is case insensitive during insert, but case sensitive during read

Manual testing scenarios (*)

  1. Create at least one additional custom stock source
  2. Create a new stock associated with the website
  3. Associate the custom sources to the new stock
  4. Utilizing the API, create an inventory source item providing incorrect source code (eg. warehouse_alpha -> waRehOuse_alPha)
  5. With this fix, an error will be logged and returned - no incorrect source items will be saved to break the admin panel

Questions or comments

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

theuargb avatar Jul 18 '24 08:07 theuargb

@magento give me 2.4-develop instance

theuargb avatar Jul 19 '24 08:07 theuargb

Hi @theuargb. Thank you for your request. I'm working on Magento instance for you.

Hi @theuargb, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@magento give me 2.4-develop instance

theuargb avatar Jul 21 '24 08:07 theuargb

Hi @theuargb. Thank you for your request. I'm working on Magento instance for you.

Hi @theuargb, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@magento give me 2.4-develop instance

theuargb avatar Aug 01 '24 14:08 theuargb

Hi @theuargb. Thank you for your request. I'm working on Magento instance for you.

Hi @theuargb, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.