inventory icon indicating copy to clipboard operation
inventory copied to clipboard

Handle Null Product Types

Open brandonbishopp opened this issue 2 years ago • 9 comments

Description (*)

Typecast product type data to stringify null values

Manual testing scenarios (*)

  1. Place an order
  2. Manually set an order item product type value to null
  3. Observe sales_order_clean exception

Contribution checklist (*)

  • [x] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

brandonbishopp avatar Apr 24 '23 13:04 brandonbishopp

@brandon-1999 Don't forget to sign the CLA so we can get this moving 🙂

pykettk avatar Apr 24 '23 20:04 pykettk

@magento run all tests

brandonbishopp avatar Apr 25 '23 08:04 brandonbishopp

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests CE

pykettk avatar Apr 25 '23 11:04 pykettk

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Functional Tests EE

pykettk avatar Apr 25 '23 11:04 pykettk

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento run Integration Tests

pykettk avatar Apr 25 '23 11:04 pykettk

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.