inventory icon indicating copy to clipboard operation
inventory copied to clipboard

Store pickup doesn' work when i add customizable option to a simple product

Open Abdallah-herri opened this issue 4 years ago • 5 comments

Preconditions (*)

Magento version 2.4.1

Steps to reproduce (*)

  1. Create a simple product.

  2. add a customizable option to this product (https://docs.magento.com/user-guide/catalog/settings-advanced-custom-options.html). Screenshot_2021-01-19 Joust Duffle Bag Products Inventory Catalog Magento Admin(1)

  3. in this customizable options settings, an arbitrary SKU must be provided, where as for other options, you can put any value

  4. activate In-Store Delivery (https://docs.magento.com/user-guide/shipping/shipping-in-store-delivery.html).

  5. create sources that are defined as pickup location (stores > sources) Screenshot_2021-01-19 Manage Sources Inventory Stores Magento Admin

  6. add sources that are defined as pickup location to this product. Screenshot_2021-01-19 Joust Duffle Bag Products Inventory Catalog Magento Admin

  7. add this product to a cart and try to proceed to a normal checkout.

Expected result (*)

The "In-Store delivery method" should be available in the checkout page (with or without the addition ofthe cutomizable option). Screenshot_2021-01-19 Checkout

Actual result (*)

If we add the customizable option to the product, the in-store delivery method breaks (the customizable option "Montage is added as shown in order summary on the right) Screenshot_2021-01-19 Checkout(1)

Additional notes

Severity (*)

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [x] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Abdallah-herri avatar Jan 19 '21 09:01 Abdallah-herri

Hi @Abdallah-herri. Thank you for your report. To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] avatar Jan 19 '21 09:01 m2-assistant[bot]

Hi @engcom-Alfa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] avatar Jan 19 '21 11:01 m2-assistant[bot]

Hi @Abdallah-herri.

Looks like this issue related to MSI functionality. @sdzhepa Could you move this ticket to the Inventory repository? Thanks!

engcom-Alfa avatar Jan 19 '21 11:01 engcom-Alfa

Hi @Abdallah-herri. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


m2-assistant[bot] avatar Feb 05 '21 22:02 m2-assistant[bot]

Bringing this back up as the issue is still present.

Sku should probably be retrieved as follows, instead of directly from the quote/order item:

  • get product id from item
  • retrieve sku for product id from db

Both for checking if In-Store Pickup is available, and for "Notify order is ready for pickup" process in admin order. To note though, order items can exist for products that may have been deleted, so this should be accounted for.

quoteItem/orderItem->getSku() returns a maybe customized sku, quoteItem->getProduct()->getSku() also returns a possibly customized sku

smartexcan avatar Sep 05 '23 13:09 smartexcan