inventory icon indicating copy to clipboard operation
inventory copied to clipboard

Published 20 hours ago • verified publisher icon magento

Product salability improvements fork

Open novikor opened this issue 4 years ago • 11 comments

See https://github.com/magento/inventory/pull/3202

Description (*)

A common version for #3140 IsProductSalable/AreProdustsSalable composite products support and #3201: Load product salability data on-demand

Fixed Issues (if relevant)

  1. Fixes #3140 IsProductSalable/AreProdustsSalable composite products support
  2. Fixes #3201: Load product salability data on-demand

Manual testing scenarios (*)

Not now

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

novikor avatar Nov 15 '20 19:11 novikor

@magento run all tests

novikor avatar Nov 15 '20 19:11 novikor

@magento run Integration Tests

novikor avatar Nov 18 '20 15:11 novikor

@magento run Functional Tests CE

novikor avatar Nov 18 '20 15:11 novikor

@magento run Integration Tests

novikor avatar Jan 04 '21 10:01 novikor

@magento run Functional Tests CE

novikor avatar Jan 04 '21 10:01 novikor

@magento run Integration Tests

novikor avatar Jan 05 '21 08:01 novikor

@magento run Functional Tests CE

novikor avatar Jan 05 '21 08:01 novikor

@magento run all tests

novikor avatar Jan 19 '21 12:01 novikor

The development part seems to be finished.

However, there are some test cases that should be covered:

  • [ ] Bundle product with disabled items frontend availability (MFTF and/or Integration):
  • Custom stock with custom source, with sales channel assigned;
  • A bundle product with a single simple bundle item assigned to the custom source, In stock;
  • The simple product has Enable Product set to No
  • Expected result: bundle product is out of stock and not available on the frontend.
  • Invalid Actual result example: image
  • [ ] Configurable product with disabled children frontend availability (Integration, already covered by MFTF: AdminConfigurableProductWithDisabledChildrenOnAdditionalStockTest):
  • Custom stock with custom source, with sales channel assigned;
  • A configurable product with a single simple child item assigned to the custom source, In stock;
  • The simple product has Enable Product set to No
  • Expected result: configurable product is out of stock and not available on the frontend (\Magento\Catalog\Model\Product::isSalable must return false).
  • [ ] Cover AreProductsSalableInterface Configurable Product compatibility (Integration)
  • [ ] Cover AreProductsSalableInterface Bundle Product compatibility (Integration)

@swnsma .

novikor avatar Jan 20 '21 11:01 novikor

@magento run all tests

novikor avatar Jan 21 '21 09:01 novikor

@magento run all tests

sidolov avatar Feb 01 '21 20:02 sidolov