inventory icon indicating copy to clipboard operation
inventory copied to clipboard

Refactor InventoryDistanceBasedSourceSelection plugin to handle exceptions

Open TadeuRodrigues opened this issue 4 years ago • 23 comments

Description (*)

Refactory InventoryDistanceBasedSourceSelection plugin to show the exceptions

Fixed Issues (if relevant)

  1. magento/inventory#2930: Refactor InventoryDistanceBasedSourceSelection plugin to handle exceptions instead of silent fail

Manual testing scenarios (*)

  1. save a source or create a new one
  2. change the 'Store>Configuration>Catalog>Inventory>Distance Provider for Distance Based SSA/Provider' to 'offiline'

Contribution checklist (*)

  • [X] Pull request has a meaningful description of its purpose
  • [X] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)

TadeuRodrigues avatar Apr 12 '20 17:04 TadeuRodrigues

@TadeuRodrigues unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@magento run all tests

novikor avatar Aug 03 '20 08:08 novikor

@magento run all tests

novikor avatar Aug 03 '20 15:08 novikor

@magento run all tests

TadeuRodrigues avatar Aug 04 '20 05:08 TadeuRodrigues

@magento run WebAPI Tests

novikor avatar Aug 04 '20 07:08 novikor

@magento run Functional Tests CE

novikor avatar Aug 04 '20 07:08 novikor

@magento run all tests

novikor avatar Aug 09 '20 15:08 novikor

@magento run all tests

novikor avatar Aug 10 '20 14:08 novikor

@magento run all tests

sidolov avatar Nov 09 '20 19:11 sidolov

@magento run Functional Tests EE

novikor avatar Nov 09 '20 21:11 novikor

Hi, @sidolov. Are there any updates?..

The failed Semantic Version Checker test is not related to the PR changes.

novikor avatar Jan 18 '21 14:01 novikor

@magento run all tests

sidolov avatar Jan 19 '21 14:01 sidolov

@magento run all tests

novikor avatar Jan 20 '21 11:01 novikor

Captura de tela de 2021-01-20 10-54-04

TadeuRodrigues avatar Jan 20 '21 14:01 TadeuRodrigues

@magento run all tests

TadeuRodrigues avatar Jan 20 '21 14:01 TadeuRodrigues

Semantic Version Checker failure is not related to the PR changes, as well as functional tests (AdminAddRemoveDefaultVideoGiftCardProductTest AdminAddRemoveDefaultVideoVirtualProductTest AdminAddRemoveDefaultVideoBundleProductTest StorefrontGalleryConfigurableProductWithVisualSwatchAttributePrependMediaTest StorefrontGalleryConfigurableProductWithSeveralAttributesPrependMediaTest).

There is something wrong with Integration Tests (failed elasticsearch connection), more likely will be green after a restart.

novikor avatar Jan 21 '21 08:01 novikor

@magento run Integration Tests

novikor avatar Jan 21 '21 08:01 novikor

@magento run Functional Tests CE

novikor avatar Jan 21 '21 09:01 novikor

@magento run Functional Tests CE

TadeuRodrigues avatar Jan 26 '21 12:01 TadeuRodrigues

@magento run Functional Tests EE

TadeuRodrigues avatar Jan 27 '21 04:01 TadeuRodrigues

@magento run Functional Tests B2B

TadeuRodrigues avatar Jan 27 '21 11:01 TadeuRodrigues

@magento run Functional Tests B2B

TadeuRodrigues avatar Jan 27 '21 18:01 TadeuRodrigues

@magento run Semantic Version Checker

TadeuRodrigues avatar Jan 28 '21 03:01 TadeuRodrigues