devdocs
devdocs copied to clipboard
magento
Incorrect versions in changelog of v1.1.14 of the quality patches
Is there an existing issue for this?
- [X] I have searched the existing issues
Which topic?
https://devdocs.magento.com/quality-patches/release-notes.html
What's wrong with the content?
It mentions Magento versions 1.3.0, 1.3.1 & 1.3.4, which never existed, so that seems to be a typo.
What changes do you propose?
Fix the version numbers
Anything else that can help to cover this?
No response
Hi @hostep. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this
- Join Magento Community Engineering Slack and ask your questions in #github channel.
![m2-assistant[bot] avatar](https://avatars.githubusercontent.com/in/27048?v=4 "Published by a pub.dev verified publisher"){kind=small}
Under 1.1.13 there is another one:
MDVA-43451 (for Adobe Commerce and Magento Open Source >=1.3.2 <1.3.4)-Fixes the issue where the error “The store that was requested wasn’t found. Verify the store and try again.” appears while configuring a shared catalog for a specific website.
And under 1.0.21 another one:
MDVA-36424 (for Magento >=1.3.0 <=1.3.3-p1 || >=2.0.0 <2.2.0)-Fixes the issue where media images, attached to page builder elements, disappear when the content is being edited repeatedly, if the backend base URL is different from the storefront base URL.
Maybe there are more? I didn't search further...
For the first two mentioned, it looks like those version ranges apply to the B2B product, and not the normal Commerce or Open Source products:
@hostep, because the https://github.com/magento/devdocs/commit/c280c70528901af47db1b5b7e43a66fd4bfba0e5 commit fixed it and the PR that merged that commit automatically closed this issue. It looks like I need to force a deploy though, since the changes didn't affect file size and the web page wasn't updated. I just kicked off a deployment. It should be finished in about 10 minutes.
Ah okay great! It's probably not being mentioned automatically over here since it was done in a private repository: https://github.com/magento-commerce/devdocs/
Any reason why this is not done over here on the public repo directly?
Also, this commit doesn't seem to fix:
MDVA-36424 (for Magento >=1.3.0 <=1.3.3-p1 || >=2.0.0 <2.2.0)-Fixes the issue where media images, attached to page builder elements, disappear when the content is being edited repeatedly, if the backend base URL is different from the storefront base URL.
Ah okay great! It's probably not being mentioned automatically over here since it was done in a private repository: https://github.com/magento-commerce/devdocs/
Any reason why this is not done over here on the public repo directly?
Yeah, you're right. All PRs are actually delivered via private repos in the magento-commerce org. That's why you see us adding the @magento import... comment on external PR contributions.
For internal PR contributions (those submitted by Adobe staff), it's more efficient to open the PR directly in the private repo so that we don't need to import it and put it through an unnecessary layer of processing.
Also, this commit doesn't seem to fix:
MDVA-36424 (for Magento >=1.3.0 <=1.3.3-p1 || >=2.0.0 <2.2.0)-Fixes the issue where media images, attached to page builder elements, disappear when the content is being edited repeatedly, if the backend base URL is different from the storefront base URL.
That wasn't part of the original report, so we didn't address that. It looks like that's part of the 1.0.21 release notes.
@jeff-matthews - I just checked this page : https://devdocs.magento.com/quality-patches/release-notes.html and all the version numbers have been corrected. Is there a reason why this issue is still open?
Looks like my last remark eventually got fixed in https://github.com/magento/devdocs/commit/3c7a6ad7df8b7b9cdac19e1f1e52218f24e212b1
Let's close this issue now finally.