devdocs icon indicating copy to clipboard operation
devdocs copied to clipboard

README content for modules - work in M2 Code

Open lorikrell opened this issue 5 years ago • 22 comments

Topic clarification/correction request

Topic Link

All modules documented in the Open Source and Commerce of the Module Reference Guide pull the content from the READMEs in Magento 2 code. To add content, create PRs to Magento 2 core!

Solution

We need Modules documented in the Magento 2 source code. 2.4: https://github.com/magento/magento2/tree/2.4-develop/app/code/Magento

  • We have a template for you to use: Magento module readme template
  • As you add PRs to Magento 2 core, add a link to this issue.
  • We can review your PR in Magento 2.
  • The merged PRs will be pulled by our doc process, automatically adding content to DevDocs!

lorikrell avatar May 07 '19 22:05 lorikrell

Hi guys, can I have this assigned to me please?

diazwatson avatar Jul 29 '19 12:07 diazwatson

@diazwatson, assigned to you. It looks like we still need to provide you with a README template before you can start work.

@dshevtsov, is there a template available?

jeff-matthews avatar Jul 29 '19 13:07 jeff-matthews

Yes please. From what I can see Readme files need to be created for all modules in m2 repo, then (once change merged) referenced in these 2 pages. Is this correct?

diazwatson avatar Jul 29 '19 13:07 diazwatson

Yes, that's correct @diazwatson.

jeff-matthews avatar Jul 29 '19 13:07 jeff-matthews

@jeff-matthews, the template is in our internal wiki and has to be published.

dshevtsov avatar Jul 29 '19 16:07 dshevtsov

@diazwatson, I attached the template to this comment. GitHub won't accept a Markdown (.md) file attachment, so I changed it to .txt. After you download it, just change the extension to .md.

module-readme-template.txt

jeff-matthews avatar Jul 29 '19 17:07 jeff-matthews

Thanks for sorting that @jeff-matthews I think I have everything to start

diazwatson avatar Jul 29 '19 20:07 diazwatson

No problem! Thanks for volunteering to work on this. I also created a public gist of the template: https://gist.github.com/magento-docbot/dfb8cc7db6519da14fc92b890d49b7d3

jeff-matthews avatar Jul 29 '19 20:07 jeff-matthews

Make sure any links that point to devdocs contain the proper version in the URL. The template shows links with "2.1".

keharper avatar Jul 29 '19 20:07 keharper

Thanks for pointing that out @keharper. I just fixed the gist, but the file attached to my previous comment still has the old 2.1 links.

jeff-matthews avatar Jul 29 '19 20:07 jeff-matthews

A bit of update in here: I am planning to submit more PR in the next few days and expecting to complete this task by the end of December

diazwatson avatar Nov 08 '19 09:11 diazwatson

Hey @diazwatson --- Are you still planning to do more work on this?

shrielenee avatar Feb 10 '20 18:02 shrielenee

Yes

diazwatson avatar Feb 10 '20 20:02 diazwatson

Removing you as assignee @diazwatson. If you want to pick this up again in the future, please do!

shrielenee avatar Sep 03 '20 19:09 shrielenee

@magento I am working on this

korovitskyi avatar Dec 16 '20 10:12 korovitskyi

Hi, @korovitskyi I think there are more modules that need to be updated. Can I also join the show? If you okay with that.

chiranjeevi-cj avatar Dec 17 '20 07:12 chiranjeevi-cj

Hi @chiranjeevi-cj ! Sure. I think you should start from the button of modules list to avoid conflicts.

korovitskyi avatar Dec 18 '20 09:12 korovitskyi

@magento I am working on this

chiranjeevi-cj avatar Dec 18 '20 09:12 chiranjeevi-cj

@magento I am working on this

vlmed avatar Jan 13 '21 10:01 vlmed

@magento I am working on this

ProkopovVitaliy avatar Jan 29 '21 12:01 ProkopovVitaliy

Great to see all this progress!

dobooth avatar Mar 03 '21 14:03 dobooth

Seemed like an unintentional closure via a closing keyword.

dshevtsov avatar Jul 29 '21 13:07 dshevtsov