data-migration-tool icon indicating copy to clipboard operation
data-migration-tool copied to clipboard

Tool does not adhere to standards checked by M2 test runner

Open cykirsch opened this issue 7 years ago • 3 comments

When I run the Magento 2 tests, the migration tool gets flagged for hundreds of small issues.

# Run the full test runner with this
bin/magento dev:tests:run
# But I personally run one at a time since there are problems with the integration tests
bin/magento dev:tests:run static

Here are examples of the 2 main issues, but there are several instances of each of them:

  • The XML file at /Users/me/Projects/m2.com/www/vendor/magento/data-migration-tool/tests/integration/testsuite/Migration/_files/map-tier-price.xml does not have a schema properly defined. It should have a xsi:noNamespaceSchemaLocation attribute defined with a URN path. E.g. xsi:noNamespaceSchemaLocation="urn:magento:framework:Relative_Path/something.xsd"
  • Incorrect namespace usage(s) found in file /Users/me/Projects/m2.com/www/vendor/magento/data-migration-tool/tests/unit/testsuite/Migration/Step/Eav/HelperTest.php:

This does not affect our ability to use the migration tool, but it significantly impedes our usage of the static test runner--it is quite difficult to see our own issues that require fixes.

cykirsch avatar May 02 '17 19:05 cykirsch

I had tried to uninstall the migration tool so I could run the tests without it, but that's not exactly straightforward. If you have any advice on that front (quickly removing/uninstalling composer package), that may also be helpful.

cykirsch avatar May 02 '17 19:05 cykirsch

Try removing vendor/magento/data-migration-tool/tests as a quick fix. Internal ticket MAGETWO-68873 to solve it.

victor-v-rad avatar May 03 '17 08:05 victor-v-rad

Great idea! That did take care of a big chunk, thanks.

cykirsch avatar May 03 '17 14:05 cykirsch