community-features icon indicating copy to clipboard operation
community-features copied to clipboard

Allow to set negative number for attribute position in layered navigation

Open Tomasz-Silpion opened this issue 5 years ago • 3 comments

Description (*)

As catalog_eav_attribute table position is an integer, it is legal and seems completely safe to set a negative position for any attribute in layered navigation. I would like to replace attribute position validation from validate-digits to integer.

Expected behavior (*)

Admin attribute edit should allow to set any positive or negative non-decimal number for position in layered navigation.

Benefits

That would allow to prioritize chosen attributes more easily.

Additional information

negative-position-of-attribute

Tomasz-Silpion avatar Nov 29 '19 02:11 Tomasz-Silpion

Hi @Tomasz-Silpion. Thank you for your report. To help us process this issue please make sure that you provided the following information:

  • [x] Summary of the issue
  • [x] Information on your environment
  • [x] Steps to reproduce
  • [x] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Tomasz-Silpion do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • [x] yes
  • [ ] no

m2-assistant[bot] avatar Nov 29 '19 02:11 m2-assistant[bot]

:white_check_mark: Confirmed by @sudheers-kensium Thank you for verifying the issue. Based on the provided information internal tickets MC-29277 were created

Issue Available: @sudheers-kensium, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team avatar Nov 29 '19 11:11 magento-engcom-team

Hello @Tomasz-Silpion

Thank you for feedback and your proposal!

Based on the description and label feature request the issue has been transferred to Magento Feature Request public repo.

Additionally, based on Issue reporting guidelines feel free to raise this topic on the next resources:

Before creating an issue, please do the following: ...

  • Make sure, that information you are about to report is a technical issue, please refer to the Community Forums or Magento Stack Exchange for technical questions, feature requests, etc. These reports are not guaranteed to be processed within GitHub issue tracker.

sdzhepa avatar May 06 '20 17:05 sdzhepa