commerce-data-export icon indicating copy to clipboard operation
commerce-data-export copied to clipboard

ISSUE-404: Sync with 2.4 - Product Feed index process unknown error

Open vgoncharenko opened this issue 4 years ago • 2 comments

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/catalog-storefront#404

Questions or comments

Code Review Checklist (*)

See detailed checklist

  • [ ] Story AC is completed
  • [ ] proposed changes correspond to Magento Technical Vision
  • [ ] new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • [ ] no backward incompatible changes
  • [ ] Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • [ ] Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • [ ] Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

vgoncharenko avatar Nov 11 '20 23:11 vgoncharenko

@magento run all tests

vgoncharenko avatar Nov 11 '20 23:11 vgoncharenko

This is a backward-incompatible change that will break all the existing clients. Please be aware that the module was release and actively in use by clients.

akaplya avatar Dec 18 '20 23:12 akaplya