architecture icon indicating copy to clipboard operation
architecture copied to clipboard

Update proposal for custom attributes schema

Open melnikovi opened this issue 4 years ago • 2 comments

Problem

Current schema for custom attributes doesn't support attributes that can have multiple values (checkbox, multiselect).

Solution

Requested Reviewers

melnikovi avatar Oct 20 '20 18:10 melnikovi

@melnikovi Does this align with the custom attribute proposal from @akaplya for Product? https://github.com/magento/architecture/pull/429

nrkapoor avatar Oct 20 '20 18:10 nrkapoor

  1. We need to make sure that data and metadata is not mixed in the same queries because they have different life cycles. Metadata can be cached on the client and reused between queries for data.
  2. Each schema modification must be covered with the example of usage. Suggestion is to split the original proposal into smaller ones, which address one problem at a time.
  3. We need to add proposed schema to the running server to make sure it is syntactically correct. For interfaces we can temporarily use an existing type resolver to bypass errors.

paliarush avatar Mar 29 '21 19:03 paliarush