architecture icon indicating copy to clipboard operation
architecture copied to clipboard

Published 20 hours ago • verified publisher icon magento

Translations in di.xml

Open buskamuza opened this issue 5 years ago • 1 comments

Problem

There are translate attribute supported in layouts, while di.xml supports translatable with different behavior. This is confusing and may lead to bugs.

See MAGETWO-67048 (internal issue with old discussion).

Solution

Unify translation attributes in XML files.

Requested Reviewers

@melnikovi @maghamed @kokoc

buskamuza avatar Aug 01 '19 19:08 buskamuza

  • @kandy : keep behavior as is. It may be impossible to implement due to di.xml being loaded too early
  • Look into all cases where translations are provided via di.xml and see if we can eliminate translations from di.xml at all.

buskamuza avatar Aug 07 '19 15:08 buskamuza