magenta-studio icon indicating copy to clipboard operation
magenta-studio copied to clipboard

Use [`jweb`] to render plugins within Live, remove Electron dependency

Open catarak opened this issue 4 years ago • 2 comments

Hello! I've reworked the Magenta plugins to remove to Electron dependency, taking advantage of the fact that now jweb (aka CEF) now runs in Live. I'm excited that the plugin no longer has to launch five different application to use Magenta within Live, woohoo!

Summary of changes

  • Updated major versions of all packages that were out of date
  • Removed Electron dependency and all related files
  • Rewrote Max patch to use [jweb]
  • Moved all plugins to be rendered as a single web application in client/index.js
  • Rewrote build process to compile plugins to one application rather than five
  • Made design changes so that the plugins fit in the Live window
  • Updated documentation
  • Updated version to 2.0.0

Feedback Needed

  • The licensing is out of date. Let me know how to update this!
  • There are some linting errors that are unrelated to any of the changes I made. Should I fix these anyway?
  • I updated the copy in the "About" section, and I removed the license information. Let me know if there are changes to make to this.
  • I tried to remove all of the unused dependencies, but for some reason, if I try to remove spectron, a testing framework for electron, it stops building, and I wasn't able to figure out why.

catarak avatar Dec 21 '21 18:12 catarak

Wow, this is amazing! We are mostly out until January, but we will take a look then. Thanks!

FYI @tambien

adarob avatar Dec 21 '21 18:12 adarob

Okay, I believe I've made all of the changes you asked for 😄

catarak avatar Jan 06 '22 20:01 catarak