magenta-js icon indicating copy to clipboard operation
magenta-js copied to clipboard

Upgrade @magenta/image to tfjs 1.0.x

Open romaincazier opened this issue 5 years ago • 4 comments

Hi,

I was trying to use the BodyPix model with Magenta but the tfjs version required is 1.0.0. Is it possible to update it ?

Thanks!

romaincazier avatar Apr 18 '19 15:04 romaincazier

Yeah, let me take a look at this today!

notwaldorf avatar Apr 23 '19 17:04 notwaldorf

Update: so unfortunately while updating to 1.0.x is fine, this breaks browserify with this error:

/Users/noms/Code/magenta-js/image/node_modules/@tensorflow/tfjs-converter/dist/src/data/compiled_api.ts:20
export declare interface IAny {
^
ParseError: 'import' and 'export' may appear only with 'sourceType: module'

I think we have to update to using webpack, like we did for @magenta/music

notwaldorf avatar Apr 23 '19 20:04 notwaldorf

I hit the same wall at some point, I (blindly) tried things but my knowledge is pretty limited here...

Thank you for looking at it!

romaincazier avatar Apr 23 '19 21:04 romaincazier

A thousand years later, I think this will be an easy fix once https://github.com/magenta/magenta-js/issues/530 is done

notwaldorf avatar Jan 05 '21 20:01 notwaldorf