mage icon indicating copy to clipboard operation
mage copied to clipboard

Token Icons will randomly change between turns

Open Alex-Vasile opened this issue 2 years ago • 1 comments

e.g. create 3 Soldier tokens with [[Captain's Call]], they will switch between different cards as the turns continue.

Alex-Vasile avatar Sep 04 '22 23:09 Alex-Vasile

Captain's Call - (Gatherer) (Scryfall) (EDHREC)

{3}{W} Sorcery Create three 1/1 white Soldier creature tokens.

github-actions[bot] avatar Sep 04 '22 23:09 github-actions[bot]

@Alex-Vasile This seems to be fixed? the card [xxx] stays the same, only the initial token will be a random soldier token, but for each spell it will use the same 3 versions,

hidde-vb avatar Sep 29 '22 21:09 hidde-vb

This seems to be fixed? the card [xxx] stays the same, only the initial token will be a random soldier token, but for each spell it will use the same 3 versions,

This issue is fixed in the case of DMU's Captain's Call specifically (because DMU token images were recently added to xmage), but the issue generally is not fixed. In xmage when a source from a set without an image for a token creates an instance of that token it will instead generate the token with a random image from a set which does have an image for that token. This is why prior to 47670266cd489871a46e5e8114536d22f73eba48 DMU cards would create tokens with images from random sets. The issue is that these token images will frequently switch to a different image whenever the battlefield "moves", i.e. permanents shrink or move to accommodate more / less permanents entering play, which seems to imply that the images for these tokens are being fetched each time the battlefield updates.

Also, thumbnail and "full" images for tokens are not synced, which is the reason that you can have a token in game displaying with a certain image on the battlefield, but displays a different full image at the top-right of the client when you hover your cursor over it.

PurpleCrowbar avatar Sep 29 '22 21:09 PurpleCrowbar

If true about images changes then it's regression from one of the commits. Must be researched.

Token images and thunbnails (small images) work fine in old versions. Maybe something lost (example: token cache key or set code from initialized token permanent).

JayDi85 avatar Sep 29 '22 21:09 JayDi85

The issue is that these token images will frequently switch to a different image whenever the battlefield "moves", i.e. permanents shrink or move to accommodate more / less permanents entering play, which seems to imply that the images for these tokens are being fetched each time the battlefield updates.

I can't reproduce images switching on battlefield update in current version. So it must be fixed.

JayDi85 avatar May 09 '23 07:05 JayDi85