mage icon indicating copy to clipboard operation
mage copied to clipboard

DMU - Dominaria United Set Card Implementation Tracking

Open theelk801 opened this issue 2 years ago • 10 comments

This checklist is here to help manage the implementation of Dominaria United. If a card is marked as being in progress then someone is working on it.

If you're new to implementing cards then you likely don't have permission to check things off. This is totally fine! We still appreciate your contributions so just leave a comment to let us know that you're working on it.

Don't worry about moving things from in progress to completed either, there's a script that handles that, and don't worry about fixing text issues as those are usually handled when the set is done.

All Sets

Unimplemented Cards

Scryfall gallery of everything currently unimplemented

Implemented Cards

Click to expand

theelk801 avatar Jul 22 '22 13:07 theelk801

Additional tasks:

  • [x] #9431
  • [x] #9407
  • [x] #9383

Mechanics article for reference

theelk801 avatar Jul 22 '22 13:07 theelk801

I wanna implement "Yavimaya Iconoclast" :)

FreaIsDead avatar Aug 22 '22 11:08 FreaIsDead

Regarding the tokens, Raven Man's token is implemented. It just needs the image download code and I'm not sure how to do that. Same for Lagomos, Hand of Hatred which also got a new token type.

weirddan455 avatar Aug 23 '22 17:08 weirddan455

Regarding the tokens, Raven Man's token is implemented. It just needs the image download code and I'm not sure how to do that. Same for Lagomos, Hand of Hatred which also got a new token type.

That can be done when the tokens have been revealed or the set releases and the images come up on Scryfall. Usually downloads for new tokens’ images are dealt with when the set releases and the tokens can just use the placeholder image until then

PurpleCrowbar avatar Aug 23 '22 17:08 PurpleCrowbar

I've implemented Ratadrabik of Urborg (Pull Request). This is my first upload, so I hope I've done everything right :-)

rockydirtbag avatar Aug 31 '22 08:08 rockydirtbag

I'm working on Baird, though it won't work correctly until @Alex-Vasile's base-P/T PR is merged.

awjackson avatar Sep 01 '22 20:09 awjackson

So that's every card being worked on except Serra Paragon. Fun fact about that card: It doesn't work with the current rules of Magic. This guy made a pretty good video explaining the situation: https://www.youtube.com/watch?v=S4VEx9TEUfw

They're surely going to have to either errata the card or change a rule and we may have to wait on that to happen so we know how to implement it.

weirddan455 avatar Sep 13 '22 23:09 weirddan455

I think it can be implemented anyway given that it's on arena and magic online

theelk801 avatar Sep 14 '22 22:09 theelk801

I think it can be implemented anyway given that it's on arena and magic online

Yea, it's a little tricky though right? With the gain ability effect being stapled onto the same static ability. I guess it can be implemented as a replacement effect? Not really sure.

It's also bugged on Arena, not that that really matters for our purposes. It applies the ability multiple times sometimes so when one thing dies, you get the gain life trigger more that once.

weirddan455 avatar Sep 14 '22 23:09 weirddan455

Seems to be straightforward that if people care that much about how it kinda technically shouldn't work, next time they're updating the comprehensive rules they'll add an exception for it. Either way I wouldn't expect the code to need to be changed (unless they decide to go full functional errata) given that XMage isn't actually word-for-word implementations of the Magic rules.

Grath avatar Sep 15 '22 02:09 Grath

Alright, we can finally close this. Thanks to everyone who contributed!

theelk801 avatar Oct 14 '22 02:10 theelk801