mage icon indicating copy to clipboard operation
mage copied to clipboard

GUI: enhancement of Stacked Tokens

Open thefnitalian opened this issue 5 years ago • 13 comments

Implementation of one token representing multiple of the same tokens in a stacked view similar to arena with a number on the token representing how many of that similar token there are similar to the attached link. https://i.redd.it/41t3vyvof5z01.png

thefnitalian avatar Dec 20 '20 01:12 thefnitalian

This would be a tremendous help/improvement. As a krenko-EDH player, I would love to see this feature.

Woogachaka avatar May 26 '21 15:05 Woogachaka

I haven’t seen any work done on this enhancement and it’s almost over two years old.

thefnitalian avatar Jul 22 '22 16:07 thefnitalian

Because a dev with knowledge of this particular code would have to dive in to fix it. No one has, but you never know.

jeffwadsworth avatar Jul 22 '22 16:07 jeffwadsworth

I am going to close this as there seems no interest in this enhancement ever being followed up on.

thefnitalian avatar Dec 20 '22 21:12 thefnitalian

Some time has passed so I’m reopening this issue with perhaps just adding in an option under settings that is a checkbox for stacking treasures, clues, etc?

thefnitalian avatar Jul 05 '23 11:07 thefnitalian

The relevant code appears to be in CardPluginImpl::sortPermanents

xenohedron avatar Jan 27 '24 03:01 xenohedron

Stacked cards feature is not about hard code — its small part and already implemented by the lands (I refactor/fix it while works on card icons/panels — you can enable it for other cards by “few lines”).

The main problem in UX — you must introduce new “gui container” logic to work with it (fake card object with useful icons and controls like popup window for more precise selections). It also can help to increase stack limit from x5 to infinite amount per stack (current x5 limit introduced due small free space on battlefield for a cards row);

Lands stacking can ignore that UX problem due lands role — rare usage in user interactions, only taps (e.g. you need only small space for mouse click). Other cards require much more interactions and fast info like P/T — stacking can hide it and make life harder for a player. Even MTGA does not solve it fully — those card moving and auto-sorting on targeting looks bad.

So the main idea behind stacked feature — prepare special GUI for it. BTW it will allow to stack user selected objects too.

JayDi85 avatar Jan 27 '24 05:01 JayDi85

I agree that for the general case of stacking any sort of permanent, a new gui container of some sort would be needed for UX.

However, there are some specific predefined tokens (rule 111.10) that have similar role to lands, without UX problem when stacking. Perhaps for now we could implement stacking specifically for Treasure, Clue, Food, Blood, Powerstone tokens?

xenohedron avatar Jan 27 '24 06:01 xenohedron

Yes, it can applied to such tokens.

JayDi85 avatar Jan 27 '24 09:01 JayDi85

Does that mean that we may see a config option in the future to allow for stacking of predifined tokens?

thefnitalian avatar Jan 30 '24 02:01 thefnitalian

Possible alternative implementation without GUI rework, only HumanPlayer improve:

IMG_0190

JayDi85 avatar Apr 13 '24 19:04 JayDi85