mage
mage copied to clipboard
magefree
Tokens must be reworked (missing tokens from old sets, broken images)
Now that pull #6190 for card images has been merged, it should be safer / easier to clean up token images in similar ways. In particular, the following issues:
- [x] #5622 Need verify checks for missing or wrong tokens (enable and run
test_checkMissingTokenDatafor more bugs/errors) - [x] #4533 Various Token Issues
- [x] #6701 missing token image in gameplay & random token img in c20 card viewer
- [x] #5767 Images: tokens source is broken (tokens.mtg.onl)
- [ ] #2158 Fallback to alternate art for cards that are missing art
Documenting that 1) a lot of tokens are linking incorrectly or are missing, and 2) if a token can't be found for a given art, we should fall back to any other art of it we do have, to minimize the number of times we show art-less tokens.
There is special test test_checkMissingTokenData with extra checks for tokens. It's disabled by default but can show different problems like wrong token class names, wrong token usage, miss constructors, miss token images in ~~card-pictures-tok.txt~~ tokens-database.txt, etc.
How can I test which Tokens I am missing? (is there a way to generate a list of missing token images?)
In the image downloader I can see I am missing 32 card images and 238 token images....
I got most of the missing card images here using the clipboard option: https://github.com/magefree/mage/issues/9249#issuecomment-1457490644
but for tokens option 8 Copy and Paste Image URLs does not seem to apply to tokens...
Here is how I figured out which ones are missing (on a linux operating system):
cd ~/xmage/xmage/mage-client/
unzip ./plugins/images/TOK.zip -d ./TOK
wget https://raw.githubusercontent.com/magefree/mage/master/Mage.Client/src/main/resources/card-pictures-tok.txt
sed -i 's/^[^:]*://' card-pictures-tok.txt
sed -i 's/|/\//' card-pictures-tok.txt
sed -i 's/|.*/.full.jpg/' card-pictures-tok.txt
nano tokens.sh
#!/bin/bash
echo "" > missing-tokens.txt
while IFS="" read -r p || [ -n "$p" ]
do
if ! [ -e "TOK/$p" ]
then
printf '%s\n' "$p"
printf '%s\n' "\"TOK/$p\", \"\"" >> missing-tokens.txt
fi
done < card-pictures-tok.txt
chmod +x tokens.sh
./tokens.sh
Now I just have to manually download the missing files reported by the script, and then recompress and replace the TOK.zip archive
It appears the 238 missing token images is False, a lot of the reportedly missing tokens seem to not actually be real cards that are listed in card-pictures-tok.txt, I did however find some missing tokens, I have listed them below:
"TOK/F12/Human.full.jpg", "https://cards.scryfall.io/large/front/3/a/3a98c51f-c55c-4bd9-853b-65b8bad5a29f.jpg?1639374040"
"TOK/F12/Wolf.full.jpg", "https://cards.scryfall.io/large/back/3/a/3a98c51f-c55c-4bd9-853b-65b8bad5a29f.jpg?1639374040"
"TOK/8ED/Rukh.full.jpg", "https://cards.scryfall.io/large/front/b/5/b5489e26-6aec-4706-9c3e-8454878fa6c3.jpg?1626891917"
"TOK/C19/Angel of Sanctions.full.jpg", "https://cards.scryfall.io/large/front/a/8/a80e1cab-ff67-459f-ab64-2c340a8e36ac.jpg?1572370656"
"TOK/C19/Heart-Piercer Manticore.full.jpg", "https://cards.scryfall.io/large/front/a/d/ad1863c6-13c8-4116-9312-32c215f88ee1.jpg?1572370671"
"TOK/C19/Horror.full.jpg", "https://cards.scryfall.io/large/front/6/1/6188c0f0-0346-46d4-8a45-ae2749bf246f.jpg?1572370790"
"TOK/CN2/Goblin.full.jpg", "https://cards.scryfall.io/large/front/c/6/c63967fe-62da-4c27-9aa7-67adc77b2baf.jpg?1561897507"
"TOK/CNS/Ogre.full.jpg", "https://cards.scryfall.io/large/front/e/f/efaa37e5-302e-4b4b-bb2d-6a0f9f80cd3f.jpg?1561758388"
"TOK/CON/Angel.full.jpg", "https://cards.scryfall.io/large/front/d/9/d902520e-b4ed-4805-9f64-096acf7c5f31.jpg?1561758186"
"TOK/CON/Elemental.full.jpg", "https://cards.scryfall.io/large/front/d/a/daf56553-2ecc-4fe8-8730-917d891f6882.jpg?1561758206"
"TOK/CSP/Marit Lage.full.jpg", "https://cards.scryfall.io/large/front/8/f/8f5c3863-c876-48a8-9bc8-be20cd61074c.jpg?1606847376"
"TOK/DD2/Elemental Shaman.full.jpg", "https://cards.scryfall.io/large/front/d/a/da6283ba-1297-4c7d-8744-f530c04194cd.jpg?1561756395"
"TOK/DST/Beast.full.jpg", "https://cards.scryfall.io/large/front/d/0/d02d5670-fff3-4011-8e45-e6843e4e8988.jpg?1561758119"
"TOK/E01/Horror.full.jpg", "https://cards.scryfall.io/large/front/8/c/8cfb1a9c-3f34-4362-bc2d-4cd584488820.jpg?1561757545"
"TOK/H17/Dragon.full.jpg", "https://cards.scryfall.io/large/front/8/e/8ee8b915-afd3-4fad-8aef-7e9cbbbbc2e4.jpg?1561757559"
"TOK/HOU/Adorned Pouncer.full.jpg", "https://cards.scryfall.io/large/front/7/1/71dc8556-a658-40e1-8a93-6a62af208a28.jpg?1562639859"
"TOK/HOU/Champion of Wits.full.jpg", "https://cards.scryfall.io/large/front/6/5/65eebe6c-5bc9-463c-b74c-eae79fc3c1b6.jpg?1562639835"
"TOK/HOU/Dreamstealer.full.jpg", "https://cards.scryfall.io/large/front/8/c/8c362d05-f2f7-4415-8937-f9f368986e61.jpg?1562639915"
"TOK/HOU/Earthshaker Khenra.full.jpg", "https://cards.scryfall.io/large/front/c/4/c4bb3bd7-5aef-495e-81ba-f5d287981dbd.jpg?1562640030"
"TOK/HOU/Proven Combatant.full.jpg", "https://cards.scryfall.io/large/front/7/c/7c9d8aac-c032-4e0d-a8ef-99a7c53c7a19.jpg?1562639879"
"TOK/HOU/Resilient Khenra.full.jpg", "https://cards.scryfall.io/large/front/c/1/c1326c5d-b5a5-4942-b15d-37830ac62c7d.jpg?1562640026"
"TOK/HOU/Sinuous Striker.full.jpg", "https://cards.scryfall.io/large/front/5/1/513f2ce9-0127-4479-b37a-a835fbada8f8.jpg?1562639802"
"TOK/HOU/Steadfast Sentinel.full.jpg", "https://cards.scryfall.io/large/front/8/7/872694ba-0666-43c1-8884-47a2e92a127c.jpg?1562639897"
"TOK/HOU/Sunscourge Champion.full.jpg", "https://cards.scryfall.io/large/front/2/8/289a9593-151e-47d0-b0de-5eb9f061515a.jpg?1562639722"
"TOK/INV/Bird.full.jpg", "https://cards.scryfall.io/large/front/2/6/26e0e196-36e6-4d7a-a76b-1c2a18270267.jpg?1561756807"
"TOK/INV/Elephant.full.jpg", "https://cards.scryfall.io/large/front/5/4/540a3b26-ca61-46c6-9e75-981cae435b2e.jpg?1561757150"
"TOK/INV/Saproling.full.jpg", "https://cards.scryfall.io/large/front/6/1/61587ac5-0cfe-4e5d-baa2-c9a458e40474.jpg?1561757278"
"TOK/MRD/Demon.full.jpg", "https://cards.scryfall.io/large/front/0/8/084c3292-c3ec-431e-b162-309b5cf6309e.jpg?1561756614"
"TOK/MRD/Myr.full.jpg", "https://cards.scryfall.io/large/front/1/8/187cf6d5-c352-48f2-b8bf-fe1bf946e2ac.jpg?1561756726"
"TOK/MRD/Pentavite.full.jpg", "https://cards.scryfall.io/large/front/4/f/4fbb0dc6-2f9e-4389-8a90-531e94009bfb.jpg?1561757118"
"TOK/ODY/Bear.full.jpg", "https://cards.scryfall.io/large/front/0/a/0a21bc37-6f21-4dda-a313-a0d75696f7fc.jpg?1561756625"
"TOK/ODY/Elephant.full.jpg", "https://cards.scryfall.io/large/front/3/d/3dc13cf6-665a-4d92-836f-b2e10ca08ecd.jpg?1561756962"
"TOK/ODY/Squirrel.full.jpg", "https://cards.scryfall.io/large/front/a/f/af7c2def-d20d-4670-8950-7042e9380844.jpg?1561757827"
"TOK/ODY/Wurm.full.jpg", "https://cards.scryfall.io/large/front/9/f/9fc04b19-e636-4868-8224-a5da75ea01c8.jpg?1561757701"
"TOK/ODY/Zombie.full.jpg", "https://cards.scryfall.io/large/front/6/5/657fa00d-ddb5-49e6-a01e-82038cccfe30.jpg?1561757307"
"TOK/PLS/Spirit.full.jpg", "https://cards.scryfall.io/large/front/1/4/14ef4815-3dfe-47b3-ad81-1506925280d3.jpg?1561756700"
"TOK/UST/Angel.full.jpg", "https://cards.scryfall.io/large/front/e/2/e2235007-b02e-463b-95e1-a8bea74a0f9d.jpg?1571508092"
"TOK/UST/Spirit.full.jpg", "https://cards.scryfall.io/large/front/4/1/41fc8b22-f6fe-4853-b80a-64ab70a41f1d.jpg?1571508521"
"TOK/UST/Thopter.full.jpg", "https://cards.scryfall.io/large/front/2/d/2d844ee2-20a0-4071-bc2c-4a58ab1dc07f.jpg?1571508393"
"TOK/UST/Vampire.full.jpg", "https://cards.scryfall.io/large/front/5/d/5d9e999f-7033-4ccd-933a-eac4105b3edc.jpg?1571508406"
"TOK/UST/Zombie.full.jpg", "https://cards.scryfall.io/large/front/5/a/5a561f84-5696-44a5-8dc1-227af883341d.jpg?1571508505"
"TOK/UST/Elemental 1.full.jpg", "https://cards.scryfall.io/large/front/7/2/72b45263-d4e9-4a53-a78b-be651e18b615.jpg?1571508472"
"TOK/UST/Beast.full.jpg", "https://cards.scryfall.io/large/front/6/1/610def80-1303-488e-bfd9-4a27f031d20e.jpg?1571508307"
"TOK/UST/Saproling.full.jpg", "https://cards.scryfall.io/large/front/8/c/8ce60642-e207-46e6-b198-d803ff3b47f4.jpg?1571508385"
"TOK/UST/Elemental 2.full.jpg", "https://cards.scryfall.io/large/front/7/0/70f1f745-9fc2-41a6-9d39-fb4964595cf5.jpg?1571508365"
"TOK/UST/Clue.full.jpg", "https://cards.scryfall.io/large/front/9/b/9b111525-0600-4bae-94a3-df8f9472388f.jpg?1571508353"
"TOK/UST/Goat.full.jpg", "https://cards.scryfall.io/large/front/c/4/c4b44a88-85e8-4f82-8968-cf1352f0fb87.jpg?1562931813"
"TOK/UST/Faerie Spy.full.jpg", "https://cards.scryfall.io/large/front/1/0/1008e47a-a8c4-4f4f-8628-ac4b8f978dd0.jpg?1562898122"
"TOK/UST/Storm Crow.full.jpg", "https://cards.scryfall.io/large/front/8/0/80165be4-c6c8-4b22-b259-c64eb4b7fc95.jpg?1562918744"
"TOK/UST/Rogue.full.jpg", "https://cards.scryfall.io/large/front/4/b/4b633d7b-6d61-4b1a-8d65-6e1f3d5ffba7.jpg?1562908763"
"TOK/UST/Brainiac.full.jpg", "https://cards.scryfall.io/large/front/a/f/af1a8115-127d-4268-a4d0-95360862e5fb.jpg?1562927573"
"TOK/UST/Goblin.full.jpg", "https://cards.scryfall.io/large/front/6/b/6be4b0d5-b3f8-4a5d-8a38-eb0e1886f655.jpg?1562915022"
"TOK/UST/Dragon.full.jpg", "https://cards.scryfall.io/large/front/4/4/44c65dfd-69be-4345-92e9-51a35a486f21.jpg?1581535681"
"TOK/UST/Squirrel.full.jpg", "https://cards.scryfall.io/large/front/5/3/53500f0f-ef65-4534-a8db-80ce73030bc1.jpg?1562910261"
"TOK/UST/Gnome.full.jpg", "https://cards.scryfall.io/large/front/d/b/dbf33cc3-254f-4c5c-be22-3a2d96f29b80.jpg?1581535770"
"TOK/UST/Construct.full.jpg", "https://cards.scryfall.io/large/front/1/9/1935902c-d84f-496a-b9f1-f96d1f5e2b84.jpg?1562899738"
"TOK/UND/Beeble.full.jpg", "https://cards.scryfall.io/large/front/9/b/9bbfa4d4-106b-4fec-86ac-b81b71a8f432.jpg?1584741596"
"TOK/UND/Goblin.full.jpg", "https://cards.scryfall.io/large/front/6/0/60f874f9-7ac2-4d1a-97e3-722db719cd1c.jpg?1584752869"
"TOK/UND/Squirrel.full.jpg", "https://cards.scryfall.io/large/front/6/6/66c6d816-d9b2-4b11-b0e1-ab00be74cbda.jpg?1584741599"
"TOK/UND/Dragon.full.jpg", "https://cards.scryfall.io/large/front/6/8/6819b8c9-73a3-4e8e-ad7a-95cffabf873a.jpg?1584741606"
"TOK/UND/Giant Teddy Bear.full.jpg", "https://cards.scryfall.io/large/front/6/2/628c542b-7579-4070-9143-6f1f7221468f.jpg?1609977149"
"TOK/GK1/Insect.full.jpg", "https://cards.scryfall.io/large/back/c/0/c06bcc5b-4ccd-452d-8579-beee6c5cbe98.jpg?1654766742"
"TOK/GK1/Elf Knight.full.jpg", "https://cards.scryfall.io/large/back/c/c/cc77373d-34d1-475b-ade9-f49bb64bff9c.jpg?1541007432"