magefree
Fix saga first chapter zcc
This is a cleaned version of #11619.
This makes it so that if a permanent is entering as the ability's zcc is being updated, then the zcc is the permanent's instead of the spell's. An ability that happens "as ~ enters" will not have a changed zcc, as it isn't put into the entering list until after those abilities have been processed. The new SigardasSplendorTest verifies this behavior.
This also centralizes the updating of ability zcc, though addDelayedTriggeredAbility is unchanged due to to d8959f1588f0556ba4f4604d5c0dbf98350333b8. The only logic change is in the getPermanentEntering check.
Fixes #11728
@JayDi85 have you gotten the time to review this? It's been on alpha for 2 weeks, and no bug was noticed with it (commander, sealed and cube games occured)
Yes, looks like it related to wrong usage of Ability::getSourceObjectZoneChangeCounter() and exile zone id (see details in #13737) -- I need to check it.
@JayDi85 Is there a problem if I merge this soon? This fixes several problems and, if later we find a better solution of some sort, is easy to remove.
Yes, looks like it related to wrong usage of
Ability::getSourceObjectZoneChangeCounter()and exile zone id (see details in #13737) -- I need to check it.
This doesn't really make sense to me. These abilities should not be using the ZCC of the card's current zone, it should be using the ZCC of the ability when the source instantiated it. The incorrect usage is when it's being used in static effects.