mage icon indicating copy to clipboard operation
mage copied to clipboard

Update Mage.Server sqlite-jdbc from 3.32.3.2 to 3.46.1.3

Open paasar opened this issue 1 year ago • 4 comments

This allows the service to be run on Apple silicon (M1, M2, M3).

paasar avatar Oct 12 '24 06:10 paasar

@JayDi85 can you please explain what's blocking this dependency upgrade?

xenohedron avatar Oct 12 '24 18:10 xenohedron

Need workable test with existing db file to confirm a workable state by unit tests, see h2 tests example (in old days h2 lib upgrade break whole db on public server cause unit tests didn’t test real data, e.g. miss migration tests).

It was last time. After some reviews I want to remove whole db stats part from a project as outdated and useless. It must be implemented another way, without binary/protobuf data saving in db. Also public stats db affected by sqlite file size limitation and can break server on too big sizes (de server catch such bugs few times on stats db size > 1 GB).

So I will remove all that code soon.

JayDi85 avatar Oct 12 '24 18:10 JayDi85

Makes sense about removing that old stats db altogether. Does that mean this dependency could be removed entirely?

xenohedron avatar Oct 12 '24 18:10 xenohedron

Yes, all sqlite databases must be removed with that dependency. User rating calculates in real time (after match finish) and do not depends on recorded game stats (records db). So all must be fine.

JayDi85 avatar Oct 12 '24 18:10 JayDi85