mage icon indicating copy to clipboard operation
mage copied to clipboard

Add a preferred printing feature to Xmage deckbuilder

Open Svyatoslav28597 opened this issue 1 year ago • 5 comments

If you create your decks outside of xmage (On scryfall or Moxfield, as an exaple) and load them into xmage - you get a wild mess of images in your deck, some secret lairs, etched foils, chinese prints, normal cards, etc. And that happens every time you load your deck, so setting images you like won't help, especially if you change a lot of cards and update frequently It would be nice if you could set each card to use specific printing every time it shows up in your deck after loading, in draft, everywhere

Svyatoslav28597 avatar Aug 01 '24 15:08 Svyatoslav28597

I don't know what exports are like from moxfield, but if you can export with set information (MTGA style) and use the import feature in the deck editor, it preserves the selected printings.

tiera3 avatar Aug 04 '24 19:08 tiera3

Yep, the request is for a feature that xmage supports already. The described issue probably has to do with the method of import/export, or support for specifying printings from the third party service. To move forward we'd need a more detailed description of exact steps to reproduce.

xenohedron avatar Aug 13 '24 04:08 xenohedron

If you create your decks outside of xmage (On scryfall or Moxfield, as an exaple) and load them into xmage - you get a wild mess of images in your deck, some secret lairs, etched foils, chinese prints, normal cards, etc. And that happens every time you load your deck, so setting images you like won't help, especially if you change a lot of cards and update frequently It would be nice if you could set each card to use specific printing every time it shows up in your deck after loading, in draft, everywhere

I understand what you mean: players can customize their favorite illustration version instead of randomly specifying it when importing. For example: I only like the new version of the large-screen tron ​​picture

siyiye avatar Aug 13 '24 09:08 siyiye

I usually do decks in Moxfield and import them to xmage. Moxfield offers 3 ways to export (Copy For Moxfield/Copy for MTGA/Copy for MTGO) and only copy for MTGO correctly imports to Xmage, since other two options load cards to sideboard or don't load them at all. While copy for MTGO correctly imports decks - the printings seem to be absolutely random and with each deck update on moxfield - you import cards again and see wierd bunch of secret lairs and chinese cards. Not sure if this is a quirk of moxfield, or I am missing something which solves this issue

Svyatoslav28597 avatar Aug 13 '24 10:08 Svyatoslav28597

For info: moxfield not fully support mtga format (export without set info). More details here #12304

JayDi85 avatar Aug 13 '24 12:08 JayDi85

Card import preferences could be stored in key/val pairs where the key is the card's name and the value is a string containing the set and card number separated by some delimiter e.g. {"Go for the Throat", "40K,201"} would reference this specific card printing.

Would it be fine to store these as preferences, maybe a new key in the registry inside HKEY_CURRENT_USER\SOFTWARE\JavaSoft\Prefs\mage\client called "importPreferences" which would contain all the pairs?

PurpleCrowbar avatar Sep 04 '24 23:09 PurpleCrowbar

It's not about import only -- it's about deck edition too. There are already exists feature to make cards oldest and non-promo: shot_240905_040619 shot_240905_041522

So:

  • it's a "favorite cards" feature;
  • must be optional and used on import and deck editing (or only on deck editing after import to simplify GUI code -- see screen above);
  • possible commands (see right click menu):
    • add selected cards to favorite list;
    • remove selected cards from favorite list;
    • replace selected/all cards by favorite list:
      • use existing favorite list;
      • if card has multiple prints then choose random versions;
    • replace selected cards by chosen set:
      • pick choice dialog with all sets list and search, see DownloadImagesDialog for example;
  • add/remove to favorite feature works anytime;
  • replace feature works in deck editor in free mode only, search btnAddLand.setVisible in DeckEditorPanel for example;
  • data stored in map/json format, search saveSplitterLocationsToSettings and loadSplitterLocationsFromSettings for example;

JayDi85 avatar Sep 05 '24 00:09 JayDi85

Moxfield and archidekt support improved in f9fd049eceb1c3650829db0fdd149dc013108e71 and it's possible to import all images now. So that's feature is not critical for deck editor now.

JayDi85 avatar Aug 10 '25 20:08 JayDi85