mage icon indicating copy to clipboard operation
mage copied to clipboard

image download issue - SLD 209/811

Open xenohedron opened this issue 1 year ago • 1 comments

from 77aba62

Including Norn's 811 SLD variant in the download list caused the 209 SLD variant to not be able to download correctly. Seemed to happen when NON_FULL_USE_VARIOUS was applied. Potentially due to some weirdness regarding 209's URL.

xenohedron avatar Jun 23 '24 01:06 xenohedron

With https://github.com/magefree/mage/commit/17507970364e146b73e9926084fd12ef095c9041 and https://github.com/magefree/mage/pull/12508 merged, it should be using https://api.scryfall.com/cards/sld/209?format=image&version=normal&include_variations=true as its second attempt to download the file after the first attempt fails due to this being a phyrexian language card. Was this not the attempted URL?

With only https://github.com/magefree/mage/commit/17507970364e146b73e9926084fd12ef095c9041 , the second URL attempted should have been https://api.scryfall.com/cards/sld/209?format=image&version=normal which should have succeeded. Though if it failed, it should have progressed to a third URL to attempt (that should fail for this card).

tiera3 avatar Jun 28 '24 00:06 tiera3

With new bulk data usage it works fine. But I don't test api links generating for it.

shot_240803_193855

JayDi85 avatar Aug 03 '24 15:08 JayDi85