Permanent’s LKI and other time related data must be persisted (read only)

Open JayDi85 opened this issue 1 year ago • 2 comments

See details in https://github.com/magefree/mage/pull/12482#discussion_r1647082016

All time related data like LKI must be persisted to static data in the moment of the save. Current code uses many dynamic methods with game param, and saved permanent return “current” object state instead really saved state. It was broken few years ago.

Possible solution: introduce Permanent:copyToSave method and return permanent object with locked (read only) characteristics.

Jun 22 '24 12:06 JayDi85

Any chance that some of this might interact with how #8775 is bugged? It'd be fantastic if that could get fixed.

Jun 22 '24 18:06 Grath

@Grath nope, I don't see any related code to Maarika, Brutal Gladiator. But I found some ideas about possible bug, see related post in https://github.com/magefree/mage/issues/8775#issuecomment-2184152245.

Jun 22 '24 18:06 JayDi85