mage icon indicating copy to clipboard operation
mage copied to clipboard

[ACR] Implement Eivor, Wolf-Kissed

Open theelk801 opened this issue 1 year ago • 3 comments

Opening this as a PR in case anyone takes issue with the interface I added or anything else

theelk801 avatar Jun 20 '24 19:06 theelk801

CardTypeAssignment is now just a strict subset of your TypeAssignment, right? Should probably just be one.

ssk97 avatar Jun 21 '24 02:06 ssk97

Have you seen PredicateCardAssignment and TargetCardAndOrCard? #11497

I think it's best to use a common target class and not a custom target (for example, that includes the possibleTargets method which your implementation is missing).

I also think it's probably cleaner to just pass in predicates rather than add a new interface and method. Since predicates are more general and thus can be extended to things that aren't types (e.g. colors) as well as and/or/not combinations.

So basically, I think all you'd have to do is change a constructor from protected to public and use:

new TargetCardAndOrCard(SubType.SAGA.getPredicate(),
        CardType.LAND.getPredicate(),
        "a Saga card and/or a land card")

xenohedron avatar Jun 21 '24 03:06 xenohedron

yeah I didn't realize that exists, I'll adapt it to use that

theelk801 avatar Jun 22 '24 16:06 theelk801