mage icon indicating copy to clipboard operation
mage copied to clipboard

Very Cryptic Command wrongly implemented (miss card variants)

Open JayDi85 opened this issue 1 year ago • 7 comments

[[Very Cryptic Command]] from un-set (Unstable). It has different variations under one name in real life. Current implementation use D version only. https://scryfall.com/search?q=very+cryptic+command

It must have all versions and each must have own name like “Very Cryptic Command A”, “ Very Cryptic Command B”, etc.

TODO:

  • [ ] implement all variants;
  • [ ] add all variants to the set;
  • [ ] add direct links to scryfall download to support it;

JayDi85 avatar Jun 13 '24 03:06 JayDi85

Very Cryptic Command - (Gatherer) (Scryfall) (EDHREC)

{1}{U}{U}{U} Instant Choose two — • Counter target black-bordered spell. • Return target creature to its owner's hand. • Untap each permanent you control with a watermark. • Roll two six-sided dice. Target player mills X cards, where X is the total of those results.

github-actions[bot] avatar Jun 13 '24 03:06 github-actions[bot]

Does xmage support things like "artist matters" or "watermark matters"?

  • Version A needs to know the artist of another card in your deck. (Currently 115 cards across 236 prints, but if a list is used then it will need to be updated if new cards get added.)
  • Version B looks like it would be okay to implement.
  • Version C looks like it would be okay to implement. (or maybe not - draw a card from an opponents library)
  • Version D is the currently implemented version.
  • Version E is the one the bot returned - and needs to know if cards have watermarks (currently 4143 cards across 6442 prints have watermarks, and the list will just get bigger as more cards are released).
  • Version F involves text-changing which has not been implemented on xmage.

In short, I think versions B (& maybe C) could easily be added, but F (and probably A and E) could not, unless one of the options gets omitted.


Can D actually put a permanent that you control but your opponent owns in your hand? Or does it send it to the opponents hand? (If the latter, then C might not be able to be implemented either.)

tiera3 avatar Jun 13 '24 05:06 tiera3

Another consideration is how this group of cards interracts with cards like [[Ashiok's Erasure]]. If you have multiple different versions in your deck, are they considered as sharing the same name for such an effect?

tiera3 avatar Jun 13 '24 06:06 tiera3

Ashiok's Erasure - (Gatherer) (Scryfall) (EDHREC)

{2}{U}{U} Enchantment Flash When Ashiok's Erasure enters the battlefield, exile target spell. Your opponents can't cast spells with the same name as the exiled card. When Ashiok's Erasure leaves the battlefield, return the exiled card to its owner's hand.

github-actions[bot] avatar Jun 13 '24 06:06 github-actions[bot]

No same names. It’s xmage limitation.

JayDi85 avatar Jun 13 '24 08:06 JayDi85

If the cards were added with the same name and NON_FULL_USE_VARIOUS, could the spell class check which printing (ie variant) was being used and add the appropriate modes to that printing?

Just a thought that would allow it to work correctly with effects such as Ashiok's Erasure mentioned above, and also not require direct download links.

I put an attempt at version B using your proposed methodology, but it had a compile error. I am not planning on fixing it, but it may be a starting point for someone else who wants to continue with this project. I will leave the other variants for other people to tackle.

tiera3 avatar Jun 14 '24 11:06 tiera3

could the spell class check which printing (ie variant) was being used and add the appropriate modes to that printing

Hmm. Yes, it's possible. You can use one card class with one card name but different images/abilities. setInfo from card's constructor give access to image info, so it's possible to setup different abilities due set and card number.

P.S. I'm not sure is it workable with copied tokens. Must be tested.

JayDi85 avatar Jun 14 '24 14:06 JayDi85