mage
mage copied to clipboard
sync part of cards zcc properly
For MDFC / Split / Others. Started from argumenting in #12184
It would make a LOT of sense to keep part of cards zcc sync. All tests are working here. MDFC are some of the cards with a lot of coverage. There is no issue ensuring the main card and the parts are in zcc sync.
Please @JayDi85, give me an example of behavior this would break. I can add unit tests if you're not convinced.
Fix #10478
- [ ] 1 - Need research.
updateZoneChangeCounter- there are many places with card overrides, unsupported errors, etc (~20 places). Only few places are legit to use like new permanent/token code. Other places needs to research for safety or potential problems. - [ ] 2 - Need improve. Must add comments to the game engine code with every new workarounds. Example: “must change zcc from main card so it will change all parts too”;
- [x] 3 - For info. That’s code is not sync a zcc, it’s “move” all parts (increment zcc of all parts). It will fail in really independent parts like Mutate and Meld’s parts (they linked with diff zcc). So don’t use same zcc for different objects in effects;
- [ ] 4 - Need research. Card can be moved by part or by main card (if it main then all parts moved too), depends on target usage. Make sure it compatible with zcc updates (no duplicated calls with +2 zcc instead +1).