mage icon indicating copy to clipboard operation
mage copied to clipboard

Make cast/play distinct for PlayFromTopOfLibraryEffect

Open Susucre opened this issue 10 months ago • 1 comments

From my (a month late) review of https://github.com/magefree/mage/pull/11946

PlayFromTopOfLibraryEffect callers should be split between the ones allowing to play lands (respecting the filter) and those than can not.

[[Elven Chorus]] being an example of the only-cast one. [[Courser of Kruphix]] & [[Isu the Abominable]] being examples of allowing Play.

All the ones restricted to cast have wrong interaction with [[Dryad Arbor]], currently allowing it to be played if it matches the filter.

I've tested the wrong behavior with Elven Chorus:

image

Susucre avatar Apr 18 '24 10:04 Susucre

Elven Chorus - (Gatherer) (Scryfall) (EDHREC)

{3}{G} Enchantment You may look at the top card of your library any time. You may cast creature spells from the top of your library. Creatures you control have "{T}: Add one mana of any color."

Courser of Kruphix - (Gatherer) (Scryfall) (EDHREC)

{1}{G}{G} Enchantment Creature — Centaur 2/4 Play with the top card of your library revealed. You may play lands from the top of your library. Landfall — Whenever a land enters the battlefield under your control, you gain 1 life.

Isu the Abominable - (Gatherer) (Scryfall) (EDHREC)

{3}{U}{U} Legendary Snow Creature — Yeti 5/5 You may look at the top card of your library any time. You may play snow lands and cast snow spells from the top of your library. Whenever another snow permanent enters the battlefield under your control, you may pay {G}, {W}, or {U}. If you do, put a +1/+1 counter on Isu the Abominable.

Dryad Arbor - (Gatherer) (Scryfall) (EDHREC)

Land Creature — Forest Dryad 1/1 (Dryad Arbor isn't a spell, it's affected by summoning sickness, and it has "{T}: Add {G}.")

github-actions[bot] avatar Apr 18 '24 10:04 github-actions[bot]