mage icon indicating copy to clipboard operation
mage copied to clipboard

Refactor: use RedirectionEffect where appropriate

Open xenohedron opened this issue 2 years ago • 1 comments

A bunch of cards implement damage redirection with a custom effect extending PreventionEffectImpl or ReplacementEffectImpl. We have the class RedirectionEffect ~~although strangely it~~ which correctly does not extend PreventionEffect. There are likely to be various subtle bugs in these custom classes, so ideally the common classes can be cleaned up, unit tests confirmed, and cards updated to use the common classes.

xenohedron avatar Jul 20 '23 23:07 xenohedron

although strangely it does not extend PreventionEffect

This is correct, as redirection effects are entirely separate from prevention effects. Damage that can't be prevented can still be redirected. Note that "Prevent that damage, ~ deals that much damage" is not a redirection effect (the source of the damage changes).

ssk97 avatar Nov 09 '25 03:11 ssk97