mage icon indicating copy to clipboard operation
mage copied to clipboard

magefile generated init should use best practices

Open johannes-gehrs opened this issue 2 years ago • 3 comments

Not sure if it's literally a bug but it seems weird to me that the magefile you generate with init does not use the built-in libraries like sh but instead they use standard library functions, e.g.

	cmd := exec.Command("go", "build", "-o", "MyApp", ".")

I could also make a PR for that but I wanted to check first whether it is intentional.

johannes-gehrs avatar Feb 25 '22 15:02 johannes-gehrs

This is a good point. I don't really know why they're written without using sh :)

Please feel free to update it :)

natefinch avatar Mar 14 '22 15:03 natefinch

I going to prepare a PR for this.

jespino avatar Jul 28 '22 17:07 jespino

Yeah, I think this is a good idea, thanks.

On Thu, Jul 28, 2022, 1:55 PM Jesús Espino @.***> wrote:

I going to prepare a PR for this.

— Reply to this email directly, view it on GitHub https://github.com/magefile/mage/issues/408#issuecomment-1198458638, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYJZSEBWAN4IJBOVHLCKLDVWLCRNANCNFSM5PKR6DZA . You are receiving this because you commented.Message ID: @.***>

natefinch avatar Aug 04 '22 17:08 natefinch