maflcko

Results 182 issues of maflcko

Fuzz timeouts may hint at bugs or performance issues. Also, they may block the fuzz CI and fuzz farms from making progress in a reasonable time. Thus, they should be...

Tests

The flag is problematic for many reasons: * It is deprecated * It is a global flag, requiring a restart to change, as opposed to a flag that can be...

RPC/REST/ZMQ

Fixes https://github.com/bitcoin/bitcoin/pull/26657#discussion_r1071362636 by adding a `version` keyword-argument to `create_self_transfer_multi`, and by passing it via `kwargs` from all other methods.

Tests

This drops support for vanilla Ubuntu Focal 20.04 and Debian (Oldstable) Bullseye. Users on those operating systems would have to stick with a previous release branch of Bitcoin Core, upgrade...

Is is possible to construct a `Span` from a reference to a `CKey`. However, the same is not possible with `std::span`. Fix that, and add a commit to verify the...

Refactoring

The goal of BIP 326 is to provide a "privacy cloak" for txs that use sequence-based locking. This is only possible for taproot inputs, as taproot spends may look identical...

Wallet
RPC/REST/ZMQ
Needs rebase

Most supported operating systems ship with clang-15 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs. For reference: * https://packages.debian.org/bookworm/clang-15...

Build system
CI failed

`std::span` removed the comparison operators, so it makes sense to remove them for the `Span` "backport" as well. Using `std::ranges::equal` also has the benefit that some `Span` temporary constructions can...

Refactoring
Needs rebase

I am not familiar with macOS, but given that https://github.com/bitcoin/bitcoin/pull/28622 prescribes a minimum of libc++-16 for macOS, doing the same on Linux could make sense? This is needed for stuff:...

Brainstorming
Build system

`std::span` allows static extents, which is a nice benefit over just `Span`. However, the interface of the two isn't identical and requires some more changes than just defining an alias....

Refactoring
CI failed