maflcko

CC @ajtowns @kallewoof

As said on the previous pull, I'd prefer if the order of the changes was inversed: First, change the existing interface methods and names, then change the internal class implementation....

Still need to review the last commit review ACK 3af5f5adbb 🍒 Show signature Signature: ``` -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 review ACK 3af5f5adbb 🍒 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p pUg+kgv/VMHBkcM/thQ5I6k4qE4vJdWFYuZQJFTe/KVPIpkC6nxuEr6Gi3staL6n...

Oh good catch. Though, I don't think your patch fixes it. Stopping the scheduler will have no effect on the queue. The event will still be triggered later on (when...

Same here, I couldn't reproduce. My next best guess would be that this is a race in the validationinterface, where the subscriber is unsubscribed at the same time that the...

For reference, my latest attempt was to add a sleep right after the best block was updated to unblock the test, but keep the event executing (hopefully while it the...

> In this case, I would expect putting an explicit SyncWithValidationInterfaceQueue call before the destructor to fix the problem. I don't think tsan is smart enough to figure out synchronization...

Steps to reproduce: ```diff diff --git a/src/index/base.cpp b/src/index/base.cpp index 88c2ce98fa..afa13c099b 100644 --- a/src/index/base.cpp +++ b/src/index/base.cpp @@ -353,6 +353,8 @@ bool BaseIndex::BlockUntilSyncedToCurrentChain() const return false; } + UninterruptibleSleep(10ms); + { //...

Review note: `const` will compile, but kill performance when `std::move` or RVO is intended.

I am actually not sure how to fix *all* copies. Sometimes the std lib will copy if asked to: ```cpp std::vector a; std::vector b; a.insert(a.end(), b.begin(), b.end());