maflcko
maflcko
There is a tidy error, which can be fixed by either removing the `=` or by adjusting the names. ``` test/txreconciliation_tests.cpp:23:39: error: argument name 'they_may_initiate' in comment does not match...
Drahty generated a coverage report in https://github.com/bitcoin/bitcoin/pull/23443#issuecomment-962189199 . Feel free to ping @DrahtBot when it needs to be updated.
Under what circumstances is a `-reindex` needed these days? Only when disabling `-prune`? Though, then you'll download from the network anyway.
Concept ACK on removing unused code
> going to bust up my caches Personally I rebase/merge every change I test on master (even if it is just a single commit back) to rule out any unintended...
Closing for now until there is more info
@ ryan, I think the idea is that there is one coin that is owned by more than one entity. There may be several (conflicting) pre-signed txs spending it and...
Looks like the test somehow went away? If #https://github.com/bitcoin/bitcoin/pull/24408 is merged soon, you can fix everything on the next rebase.
good first issue? :trollface:
Cleared the milestone for now. This can happen anytime but shouldn't hold up the next release.