maester365
🙏 All Tests for Github Action
Describe the feature
Addition of Microsoft Exchange, Teams and Security & Compliance Connections to the Maester Github Action. The corresponding tests are currently "not run" because of missing connection to their services. The implementation would require non-interactive authentication for automation.
How will this feature enhance your project and further the project’s overall goals? Who will benefit from this feature (i.e. all users, the project team)?
The already existing tests are currently not being run.
Describe alternatives you've considered
No alternative to include the tests besides the above mentioned implementation in the GitHub action.
Additional context
See #994 for clarification and ongoing discussion about using tags to run all tests. An issue can also be opened in maester365/maester-action for this feature request.
Thanks for clarification. However, the underlying issue is that there is no connection made to the necessary services (EXO, Security & Compliance) which results in the tests not being run even if specified with the correct scoping (via Tags e.g.)
I think the user experience could be improved (show hint or another status), but it can be used with a basic understanding of how maester works. In technical terms, there is no alternative to request these settings over Microsoft Graph at the moment.
What would you have expected to see, or are the documentations unclear?
My request is for the necessary connections to be added to the Github action. There are ways to add it manually afterwards - however it should be part of the action itself imho. What's the sense of having the option to automate Maester via a Github action if only half the available tests are being run?
There are opportunities to improve documentation and test coverage when running via CI/CD pipelines. Has anyone tested the Az, ExchangeOnline, and MicrosoftTeams modules in this context yet?
@SamErde for gitlab i added some code in https://github.com/maester365/maester/pull/1065. After feedback, update and than accept the pull request i can look to add something for github actions. But first i need to know if my other PR is ok or if there are some wishes for changes.
@adam-kriese if i set the "include_%service%" to true all the services will be connected and check will be executed. https://maester.dev/docs/monitoring/github#create-github-action-worklow-for-maester
What i saw is that IPP (Purview) is missing. So, i added it to the maester actions: https://github.com/maester365/maester-action/pull/18 But there is a bug to solve.
Are there other services that won't connect but are necessary?