Markus Mächler

Results 69 comments of Markus Mächler

I started digging into this a little more and I think we'd really have to address both of these instances to reduce the number of change detection runs: https://github.com/damienbod/angular-auth-oidc-client/blob/33372edf11ec304598d0777fac4b219165e840c6/projects/angular-auth-oidc-client/src/lib/iframe/check-session.service.ts#L226-L231 https://github.com/damienbod/angular-auth-oidc-client/blob/3de72d57b53f479f946d30b9b77a5bfa975aec79/projects/angular-auth-oidc-client/src/lib/callback/interval.service.ts#L22-L24...

@damienbod @FabianGosebrink What do you think about this? I still think it would be useful and also feasible to implement my 3. suggestion, adding a config to opt-out of these...

Agree, I just thought it would be nice not to make it a breaking change. I think simply removing `zone.run` could potentially break `checkSessionChanged$` and `eventService` subscribers that rely on...

@braukma Could you please also provide the full source of the SVG file to this issue here?

@braukma I think it didn't work. I don't see an image in your second comment and the images in the first comment are only available as PNG. You could just...

@h-e-l-l-o-w-o-r-l-d Thanks for reporting! I just double checked the current release with TYPO3 v12 and v13, it seems to work with both versions for me. I didn’t use a route...

@h-e-l-l-o-w-o-r-l-d Ah, I'm sorry. I overlooked this and just wanted to make sure the static TypoScript `pdfviewhelpers - EXT:news` works as expected. I'm afraid I don't know what the issue...

The only thing that comes to my mind that could cause this, is the new TypoScript condition here: https://github.com/bithost-gmbh/pdfviewhelpers/commit/54ca87b7114fb42fa01543a2c26fe33dd3979975#diff-695419c44016793e54140ca04b222fbdaaf68ef889c0418436ce2131d1ed87da You could try providing the TypoScript in that file yourself and...

Thanks for the update! Unfortunately I also haven't made any progress on this topic and I still can't think of anything in `EXT:pdfviewhelpers` that could be causing this. Regarding your...