Mads Marquart

Results 1240 comments of Mads Marquart

(FYI, there's [RFC 3750](https://github.com/rust-lang/rfcs/pull/3750) for adding something like `#[cfg(feature = "OSX_10_14")]` built-in to the language, to allow setting this automatically with the `MACOSX_DEPLOYMENT_TARGET` env var instead of mucking around with...

I didn't mean to imply that we should cut down on test _coverage_; I only meant that I fear that the way our current CI runs may be overly wasteful,...

A problem with the `dark-light` crate is that it requires checking continually whether the theme has changed.

In general, I'm a bit inclined to think that `-shared` is an anti-feature of `cc-rs`, since: - You never want this in a `build.rs` script, since then you need to...

> The purpose of submitting this commit was to implement a C/C++ UDF with Rust's compute engine. It's fine for me to just call a bash command in build.rs. Hmm,...

> Since I didn’t want to introduce a breaking change, I added the link_shared_flag function to properly support dynamic linking. I don't think this should _really_ be seen as a...

Huh? We should be passing `--target=aarch64-unknown-none`, that's what `src/target/generated.rs` is _for_: https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/src/target/generated.rs#L33 I wonder why this isn't working?

I cannot reproduce this with `cargo build --target aarch64-unknown-none-softfloat` in a basic `build.rs` that builds an empty C file. Could you post a minimal reproducer / post the contents of...

Well, in that case it's definitely https://github.com/rust-lang/cc-rs/pull/1413. But I still cannot reproduce it, nor even fathom what the issue could be? If you don't want to post a full reproducer,...

Odd, that sounds like you're missing a `rustup target add aarch64-unknown-none-softfloat`?