Mads Marquart

Results 1240 comments of Mads Marquart

Thanks for the input @MarijnS95! You're right that I was mistaken in my original solution, and I've changed the approach in the PR (only add initialization closure, don't touch `can_create_surfaces`),...

> In general I'd prefer exploring type state patterns during runtime then just having a closure What do you mean by this? Something like https://github.com/rust-windowing/winit/pull/3710? > it won't really solve...

> ```rust > impl ApplicationHandler for Inactive {} > impl ApplicationHandler for Active {} > ``` > > and a way to switch between them during a runtime with something...

> Can macOS backend provide safe area when the transparent decorations are used? The ones where the buttons are over the main surface. Didn't even know we had `WindowAttributesExtMacOS::with_titlebar_transparent`, but...

I have ensured that `safe_area` includes the title bar when `with_titlebar_transparent` + `with_titlebar_hidden` is set on macOS

I have implemented `surface_position` on all platforms now. Most of them were trivial, but **please test it on X11 and Windows**, as I am a bit unsure I got those...

Hmm, if you set the terminal viewport to only be the safe area, what does Alacritty intend to draw in the unsafe area, then?

Okay, so if it's something that _only_ affects Alacritty, then I'd argue that we don't need the event, since Alacritty only works on desktop anyhow, and I'm fine for now...

I'm mostly against such an event because if we want it to be useful, we also have to emit it every time we do `SurfaceResized`, on every platform, and _that's_...

@daxpedda and I talked about this today, and a rough conclusion was to calculate the safe area independently of the scroll position of the page, i.e. in a sort of...