react-native-image-sequence icon indicating copy to clipboard operation
react-native-image-sequence copied to clipboard

fix memory leak

Open jinshiyi11 opened this issue 4 years ago • 3 comments

in loadBitmapByExternalURL,InputStream not closed

jinshiyi11 avatar Mar 06 '20 09:03 jinshiyi11

Is it the source problem of the issue #2 ?

JohnBerd avatar Mar 12 '20 11:03 JohnBerd

Tested today, your module makes crash the application when it reaches 0% free, Thanks to this pull request, the memory used remains the same.

NativeAlloc concurrent copying GC freed 31199(1117KB) AllocSpace objects, 12(528KB) LOS objects, 49% free, 6MB/13MB, paused 245us total 100.438ms

Please accept the pull request which is excellent, no more crash with it.

JohnBerd avatar Mar 12 '20 18:03 JohnBerd

This also solved my issue. The app would totally freeze due to too many files being open. I cloned the fork from @jinshiyi11 and works nicely. It would be excellent if this could be merged.

bwindsor avatar Apr 17 '20 07:04 bwindsor