react-native-image-capinsets icon indicating copy to clipboard operation
react-native-image-capinsets copied to clipboard

Added a null check to setCapInsets, updated build.gradle file

Open yurykorzun opened this issue 5 years ago • 3 comments

  1. Added a null check to the setCapInsets method. Usually it's never called before the uri is set, but in one case it happened in reserve and failed with an error. I don't see a reason to not have the check.
  2. Updated build.gradle file to support external project variables. Updated gradle wrapper version for 0.59 RN support.

yurykorzun avatar Mar 25 '19 13:03 yurykorzun

Why not update the reload method to early return? Btw for me this happens since 0.60

EyMaddis avatar Jul 31 '19 12:07 EyMaddis

Can this be merged?

yurykorzun avatar Mar 17 '20 17:03 yurykorzun

Please merge this, without this fix I was unable to use the library. With this fix, it just works :) Thanks!

lorg avatar Aug 15 '20 11:08 lorg