VarShapeOsc sync flag seems to be backward

[jamshark70]

Describe the bug Sync flag seems reversed from documentation.

To Reproduce

a = {
	var sig = VarShapeOsc.ar(LFDNoise3.kr(2).exprange(100, 500), 0.5, 0.5, 0);
	(sig * 0.05).dup
}.play;

Expected behavior With sync disabled (0), we should hear the frequency modulation.

Instead we hear a constant frequency matching the default sync frequency.

[madskjeldgaard]

Thanks! I am taking a break from maintaining these plugins but let me know if you want to do a PR :)

[jamshark70]

OK, I can try a PR. Would you recommend to change the documentation, or the behavior? Backward compatibility seems like it could only be quite odd: an input named sync where 0 = enable, 1 = disable. This will confuse.

[jamshark70]

BTW my ability to work on the C++ side would be somewhat hampered by:

git clone https://github.com/madskjeldgaard/portedplugins
// OK

cd portedplugins
// OK

git submodule update --init --recursive
// nothing happens

[madskjeldgaard]

BTW my ability to work on the C++ side would be somewhat hampered by:

git clone https://github.com/madskjeldgaard/portedplugins
// OK

cd portedplugins
// OK

git submodule update --init --recursive
// nothing happens

Thanks for looking into this, James. There aren't any submodules in the project anymore, I should update the info, sorry about that