guttersynth-sc icon indicating copy to clipboard operation
guttersynth-sc copied to clipboard

Redundant argument in Distortion method

Open jamesb93 opened this issue 4 years ago • 1 comments

Hi again !

sorry to be a nag, but I'm just pulling apart the code for myself atm. On this line: https://github.com/madskjeldgaard/guttersynth-sc/blob/06a2b7c6ba79c6c22fc7a742dd18367dbe5c1003/plugins/GutterSynth/GutterSynth.cpp#L78

An argument finalY is specified for the distortion algorithm but it is never used internally. Is this redundant?

jamesb93 avatar Jul 23 '21 14:07 jamesb93

Hi James. Thanks, you're totally right! I think this value might have been used for something in the original algorithms but we don't use them now. Thanks for pointing out

madskjeldgaard avatar Aug 07 '21 14:08 madskjeldgaard