Arduino-PS2X icon indicating copy to clipboard operation
Arduino-PS2X copied to clipboard

Published 20 hours ago • verified publisher icon madsci1016

Minor fixes in 1.9and port to ESP8266

Open akastulin opened this issue 5 years ago • 1 comments

Hi Guys, I have a version based on v1.9 that is working with ESP8266, Plus I fixed couple of bugs related to PIC. Would you like me to upload my code? By the way this is the first time I'm using github, so thank you for your patience.... PS2X_lib.zip

Regards

akastulin avatar Jan 22 '19 18:01 akastulin

We usually do only one thing in a PR. You did these in this PR:

  1. updated timing (is this update only applicable to Lynxmotion controller?)
  2. added LICENSE
  3. renamed .pde to .ino
  4. updated pin in example
  5. added Mega example
  6. added a .zip file

As a fellow OSS contributor, here are my 2 cents:

  • I think 2,3 is long due and okay to be bundled with some PR, but personally I would open new PR for 2
  • I don't see how ESP8266 is supported (via pin update?), and there's already merged PR https://github.com/madsci1016/Arduino-PS2X/pull/9
  • please explain if the timing update is specific to Lynxmotion controller
  • what is the bugfix actually?
  • we would not commit binary (.zip) to Arduino library, the zip is generated by GitHub's "Download ZIP" link
  • we usually merge commits before submitting PR
  • you should rebase your branch to master and resolve the conflict

leesei avatar Jul 10 '19 06:07 leesei